-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Taxonomy.required, make allow_multiple True by default [FC-0030] #91
Conversation
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
a958e98
to
946df48
Compare
946df48
to
47d3822
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of minor nits, but this is good to merge once they're addressed.
Oh and we probably need a version bump?
Thanks @bradenmacdonald !
👍
- I tested this by installing this branch on my devstack, and ensuring that the added migrations update ok from
main
. - I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A - Commit structure follows OEP-0051
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradenmacdonald Looks good 👍 Thanks!
Thanks for the reviews! |
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Part of openedx/modular-learning#85 , follows #87 .
This removes the
Taxonomy.required
field which we don't really need and isn't in the UX designs.It also makes
allow_multiple
True by default since all user-created taxonomies will need to allow multiple tags and for the MVP we don't plan on implementing any way for users to change Taxonomies to not allow multiple tags.It also removes the language tags fixture because language tags are now auto-created as needed when the system goes to tag something by language. And because removing the
required
field made the fixture stop working in its migration.There is a corresponding edx-platform PR as well: openedx/edx-platform#33438
Private-ref: FAL-3477