Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Taxonomy.required, make allow_multiple True by default [FC-0030] #91

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

bradenmacdonald
Copy link
Contributor

@bradenmacdonald bradenmacdonald commented Oct 4, 2023

Part of openedx/modular-learning#85 , follows #87 .

This removes the Taxonomy.required field which we don't really need and isn't in the UX designs.

It also makes allow_multiple True by default since all user-created taxonomies will need to allow multiple tags and for the MVP we don't plan on implementing any way for users to change Taxonomies to not allow multiple tags.

It also removes the language tags fixture because language tags are now auto-created as needed when the system goes to tag something by language. And because removing the required field made the fixture stop working in its migration.

There is a corresponding edx-platform PR as well: openedx/edx-platform#33438

Private-ref: FAL-3477

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 4, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bradenmacdonald bradenmacdonald force-pushed the braden/remove-required branch 2 times, most recently from a958e98 to 946df48 Compare October 4, 2023 19:24
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of minor nits, but this is good to merge once they're addressed.

Oh and we probably need a version bump?

Thanks @bradenmacdonald !

👍

  • I tested this by installing this branch on my devstack, and ensuring that the added migrations update ok from main.
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • Commit structure follows OEP-0051

openedx_tagging/core/tagging/api.py Outdated Show resolved Hide resolved
openedx_tagging/core/tagging/rest_api/v1/views.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradenmacdonald Looks good 👍 Thanks!

@bradenmacdonald
Copy link
Contributor Author

Thanks for the reviews!

@bradenmacdonald bradenmacdonald merged commit 909e3f8 into main Oct 6, 2023
7 checks passed
@bradenmacdonald bradenmacdonald deleted the braden/remove-required branch October 6, 2023 02:49
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants