Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] Fix incorrect number of items in DataTable component #2598

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

khudym
Copy link
Contributor

@khudym khudym commented Sep 6, 2023

Description

Fix display of number in DataTable
Issue

Deploy Preview

View Switching

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Sep 6, 2023
@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7c8fec0
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64f88bbc2a5435000800dfd7
😎 Deploy Preview https://deploy-preview-2598--paragon-openedx.netlify.app/components/datatable
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openedx-webhooks
Copy link

Thanks for the pull request, @khudym!

When this pull request is ready, tag your edX technical lead.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0ef92d9) 91.69% compared to head (7c8fec0) 91.69%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2598   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files         235      235           
  Lines        4214     4214           
  Branches     1021     1021           
=======================================
  Hits         3864     3864           
  Misses        346      346           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorrusakov
Copy link
Contributor

@khudym Changes look good, but commitlint pipeline is failing, please update you latest commit message according to the rules we have in the repo.

@khudym khudym force-pushed the fix-incorrect-number-datatable branch from 45cfc89 to 7c8fec0 Compare September 6, 2023 14:24
@viktorrusakov viktorrusakov merged commit b8bdc7b into openedx:master Sep 6, 2023
9 checks passed
@openedx-webhooks
Copy link

@khudym 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BD-46] Incorrect number of items in DataTable component
4 participants