fix: use kebab-case-ids in autosuggest esc test #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2717 +/- ##
==========================================
+ Coverage 92.75% 92.83% +0.07%
==========================================
Files 235 235
Lines 4238 4241 +3
Branches 1028 1029 +1
==========================================
+ Hits 3931 3937 +6
+ Misses 303 300 -3
Partials 4 4
☔ View full report in Codecov by Sentry. |
adamstankiewicz
approved these changes
Oct 12, 2023
|
🎉 This PR is included in version 21.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 22.0.0-alpha.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2556 didn't have conflicts and all tests had passed when I merged it, but the test was using old test ids (snake_case instead of kebab-case).
This fixes the test by updating the ids used to kebab-case.
Post-merge Checklist