-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow consumers to configure ModalDialog to allow overflow #2939
feat: allow consumers to configure ModalDialog to allow overflow #2939
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
&.pgn__modal-visible-overflow { | ||
overflow: visible; | ||
|
||
.pgn__modal-body { | ||
overflow: visible; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try this. I think this option looks better:
&.pgn__modal-visible-overflow { | |
overflow: visible; | |
.pgn__modal-body { | |
overflow: visible; | |
} | |
} | |
&.pgn__modal-visible-overflow .pgn__modal-body { | |
overflow: visible; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't work as we need to overflow both pgn__modal-body
and pgn__modal
. Your suggestion is missing the
&.pgn__modal-visible-overflow {
overflow: visible;
}
part.
1404b77
to
2f7f60c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2939 +/- ##
=======================================
Coverage 93.00% 93.00%
=======================================
Files 236 236
Lines 4273 4273
Branches 1033 1033
=======================================
Hits 3974 3974
Misses 295 295
Partials 4 4 ☔ View full report in Codecov by Sentry. |
2f7f60c
to
fc31ad7
Compare
Thank you for this PR @brian-smith-tcril! 👍 I found a nit: The top border of the dialog is not rounded after setting the overflow. But if it's not easily fixed, I don't think this should prevent this PR from getting merged. |
6b611a0
to
a1acfa0
Compare
|
a1acfa0
to
2fb98e0
Compare
🎉 This PR is included in version 22.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Resolves #2938
Deploy Preview
Playground
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist