Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default branch when openedx.org/release annotation is empty #511

Closed
wants to merge 1 commit into from

Conversation

cmltaWt0
Copy link
Contributor

@cmltaWt0 cmltaWt0 commented May 8, 2024

The bug is hard to detect.

The tool shows the correct count of repos to be cut but the result list lacks repos with null values in openedx.org/release annotation.

Find commits  : 100%|█████████████████████████| 45/45 [00:33<00:00,  1.36it/s]

Without the fix (41):

openedx/aspects-dbt
openedx/course-discovery
openedx/credentials
openedx/cs_comments_service
openedx/docs.openedx.org
openedx/ecommerce-worker
openedx/ecommerce
openedx/edx-documentation
openedx/edx-notes-api
openedx/edx-platform
openedx/enterprise-access
openedx/enterprise-catalog
openedx/enterprise-subsidy
openedx/event-bus-redis
openedx/frontend-app-account
openedx/frontend-app-authn
openedx/frontend-app-communications
openedx/frontend-app-course-authoring
openedx/frontend-app-discussions
openedx/frontend-app-ecommerce
openedx/frontend-app-gradebook
openedx/frontend-app-learner-dashboard
openedx/frontend-app-learner-record
openedx/frontend-app-learning
openedx/frontend-app-ora-grading
openedx/frontend-app-ora
openedx/frontend-app-payment
openedx/frontend-app-profile
openedx/frontend-app-publisher
openedx/frontend-app-support-tools
openedx/frontend-plugin-framework
openedx/license-manager
openedx/openedx-app-android
openedx/openedx-app-ios
openedx/openedx-demo-course
openedx/openedx-test-course
openedx/platform-plugin-aspects
openedx/testeng-ci
openedx/tutor-contrib-aspects
openedx/xblock-skill-tagging
openedx/xqueue

With fix (45):

openedx/aspects-dbt
openedx/axim-engineering
openedx/course-discovery
openedx/credentials
openedx/cs_comments_service
openedx/docs.openedx.org
openedx/ecommerce-worker
openedx/ecommerce
openedx/edx-documentation
openedx/edx-lint
openedx/edx-notes-api
openedx/edx-platform
openedx/enterprise-access
openedx/enterprise-catalog
openedx/enterprise-subsidy
openedx/event-bus-redis
openedx/frontend-app-account
openedx/frontend-app-authn
openedx/frontend-app-communications
openedx/frontend-app-course-authoring
openedx/frontend-app-discussions
openedx/frontend-app-ecommerce
openedx/frontend-app-gradebook
openedx/frontend-app-learner-dashboard
openedx/frontend-app-learner-record
openedx/frontend-app-learning
openedx/frontend-app-ora-grading
openedx/frontend-app-ora
openedx/frontend-app-payment
openedx/frontend-app-profile
openedx/frontend-app-publisher
openedx/frontend-app-support-tools
openedx/frontend-plugin-framework
openedx/frontend-template-application
openedx/license-manager
openedx/openedx-app-android
openedx/openedx-app-ios
openedx/openedx-demo-course
openedx/openedx-test-course
openedx/platform-plugin-aspects
openedx/repo-tools
openedx/testeng-ci
openedx/tutor-contrib-aspects
openedx/xblock-skill-tagging
openedx/xqueue

@openedx-webhooks
Copy link

Thanks for the pull request, @cmltaWt0! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 8, 2024
@cmltaWt0
Copy link
Contributor Author

cmltaWt0 commented May 8, 2024

@kdmccormick @feanil
This is a proposed change to use default branch when we have a null values in openedx.org/release annotation.

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not treat "null" as "default branch"--I think that would be surprising behavior for people reading catalog-info.yml files. When I see "null", I think "not applicable".

If we do want new repos to be in the release, I think we should update frontend-template-app and edx-cookiecutters to use main/master.

Alternatively, we could just exclude new repos from the release until they explicitly opt-in by adding a branch to catalog-info.yml

@cmltaWt0
Copy link
Contributor Author

cmltaWt0 commented May 8, 2024

Closing the PR as we decided that the current behaviour is desired.

@cmltaWt0 cmltaWt0 closed this May 8, 2024
@openedx-webhooks
Copy link

@cmltaWt0 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants