Merge pull request #937 from openedx/cag/sink-perf

perf: improve init lms task time by using settings instead of waffle flags
openedx · Sep 11, 2024 · 68b75dd · 68b75dd
2 parents 3ec4f93 + 7100cdc
commit 68b75dd
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/tutoraspects/patches/openedx-common-settings b/tutoraspects/patches/openedx-common-settings
@@ -59,3 +59,10 @@ EVENT_BUS_PRODUCER_CONFIG.update(
 if not "openedx_events" in INSTALLED_APPS:
 	INSTALLED_APPS.append("openedx_events")
 {% endif %}
+
+
+{% for model in EVENT_SINK_MODELS_ENABLED %}
+EVENT_SINK_CLICKHOUSE_{{model.upper()}}_ENABLED = True{% endfor %}
+{% if ASPECTS_ENABLE_PII %}# User PII models
+{% for model in EVENT_SINK_PII_MODELS %}EVENT_SINK_CLICKHOUSE_{{model.upper()}}_ENABLED = True
+{% endfor %}{% endif %}
diff --git a/tutoraspects/plugin.py b/tutoraspects/plugin.py
@@ -40,7 +40,7 @@
         ("DOCKER_IMAGE_VECTOR", "timberio/vector:0.30.0-alpine"),
         (
             "EVENT_SINK_MODELS_ENABLED",
-            ["course_overviews", "tag", "taxonomy", "object_tag"],
+            ["course_overviews", "tag", "taxonomy", "object_tag", "course_enrollment"],
         ),
         (
             "EVENT_SINK_PII_MODELS",

diff --git a/tutoraspects/templates/aspects/jobs/init/lms/init-lms.sh b/tutoraspects/templates/aspects/jobs/init/lms/init-lms.sh
@@ -36,13 +36,3 @@ EOF
 ./manage.py lms manage_user tutor-contrib-aspects aspects@axim --unusable-password
 ./manage.py lms populate_model -f /tmp/erb_config.json -u tutor-contrib-aspects
 {% endif %}
-
-{% for model in EVENT_SINK_MODELS_ENABLED %}
-(./manage.py lms waffle_flag --list | grep event_sink_clickhouse.{{model}}.enabled) || ./manage.py lms waffle_flag --create event_sink_clickhouse.{{model}}.enabled --everyone
-{% endfor %}
-
-{% if ASPECTS_ENABLE_PII %}
-  {% for model in EVENT_SINK_PII_MODELS %}
-(./manage.py lms waffle_flag --list | grep event_sink_clickhouse.{{model}}.enabled) || ./manage.py lms waffle_flag --create event_sink_clickhouse.{{model}}.enabled --everyone
-  {% endfor %}
-{% endif %}