Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add transifex automatic translations #238

Merged
merged 1 commit into from
Aug 2, 2023
Merged

feat: add transifex automatic translations #238

merged 1 commit into from
Aug 2, 2023

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Aug 1, 2023 •
edited
Loading

Description

This PR:

  • Creates a workflow to automatically push strings to transifex.
  • Creates a workflow to weekly update the translated strings.
  • Updates the create_assets implementation to get strings from a new format grouped by lang

@Ian2012 Ian2012 requested a review from bmtcril August 1, 2023 20:28
@Ian2012 Ian2012 force-pushed the cag/transifex-workflow branch 6 times, most recently from 1b0556f to 0d911c8 Compare August 1, 2023 23:22
@Ian2012
Copy link
Contributor Author

Ian2012 commented Aug 2, 2023 •
edited
Loading

Tests for dev|local|k8s are failing just because the locale.yaml file is empty and the file is loaded as None (to trigger the two translation workflows)

@Ian2012 Ian2012 force-pushed the cag/transifex-workflow branch 2 times, most recently from 944583d to 6fe62ef Compare August 2, 2023 15:04
@Ian2012 Ian2012 marked this pull request as ready for review August 2, 2023 15:06
bmtcril
bmtcril reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice solution, just a couple little things

.github/workflows/compile-translations.yaml Show resolved Hide resolved
tutoraspects/templates/aspects/apps/superset/pythonpath/create_assets.py Outdated Show resolved Hide resolved
@Ian2012
Copy link
Contributor Author

Ian2012 commented Aug 2, 2023

@bmtcril ready

@Ian2012 Ian2012 merged commit 0bef38f into main Aug 2, 2023
5 checks passed
@Ian2012 Ian2012 deleted the cag/transifex-workflow branch August 2, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmtcril bmtcril bmtcril approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ian2012 @bmtcril