Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use dbt models for problem datasets #272

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

SoryRawyer
Copy link
Contributor

@SoryRawyer SoryRawyer commented Aug 3, 2023

Converts fact_problem_responses and fact_learner_problem_summary from virtual to physical datasets, relying on models created by dbt. Relies on changes in the corresponding aspects-dbt PR. If and when those changes get approved I will mark this PR as ready to review.

Converts `fact_problem_responses` and `fact_learner_problem_summary`
from virtual to physical datasets, relying on models created by dbt.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 3, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 3, 2023

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, v1.3 of aspects-dbt is released with the prerequisite changes.

@SoryRawyer SoryRawyer marked this pull request as ready for review August 4, 2023 15:27
@SoryRawyer
Copy link
Contributor Author

Gah, sorry, this is blocked by a bug in the dbt project. I'll put this back into draft status until I can open a new PR to the dbt project.

@SoryRawyer SoryRawyer marked this pull request as ready for review August 7, 2023 15:09
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Just a heads up, there are big changes to multi-response problems coming down in the somewhat near term. Shouldn't impact this PR right now. They're going to be something of a pain to model, but it seems like the only way to correctly capture those problems: openedx/event-routing-backends#325

@bmtcril bmtcril merged commit 0670e79 into openedx:main Aug 7, 2023
5 checks passed
@openedx-webhooks
Copy link

@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants