-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Course Comparison Dashboard #931
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian2012
reviewed
Sep 4, 2024
tutoraspects/templates/openedx-assets/queries/course_tag_filter.sql
Outdated
Show resolved
Hide resolved
Ian2012
reviewed
Sep 4, 2024
tutoraspects/templates/openedx-assets/queries/watched_video_duration.sql
Outdated
Show resolved
Hide resolved
Ian2012
reviewed
Sep 4, 2024
...cts/build/aspects-superset/openedx-assets/assets/dashboards/Course_Comparison_Dashboard.yaml
Outdated
Show resolved
Hide resolved
Ian2012
reviewed
Sep 4, 2024
...cts/build/aspects-superset/openedx-assets/assets/dashboards/Course_Comparison_Dashboard.yaml
Outdated
Show resolved
Hide resolved
saraburns1
force-pushed
the
saraburns1_coursecomparedash
branch
2 times, most recently
from
September 9, 2024 14:43
48e7af5
to
921d736
Compare
Ian2012
reviewed
Sep 9, 2024
...emplates/aspects/build/aspects-superset/openedx-assets/assets/charts/Course_Info_e0098c.yaml
Outdated
Show resolved
Hide resolved
Ian2012
reviewed
Sep 9, 2024
...es/aspects/build/aspects-superset/openedx-assets/assets/charts/Enrollment_Counts_2f2af8.yaml
Outdated
Show resolved
Hide resolved
saraburns1
force-pushed
the
saraburns1_coursecomparedash
branch
from
September 10, 2024 13:53
b97430c
to
2d03f13
Compare
bmtcril
reviewed
Sep 10, 2024
saraburns1
force-pushed
the
saraburns1_coursecomparedash
branch
from
September 10, 2024 20:36
2d7ae0e
to
9162ac6
Compare
Ian2012
reviewed
Sep 11, 2024
Comment on lines
11
to
13
from {% endraw -%} {{ ASPECTS_EVENT_SINK_DATABASE }}.watched_video_duration{%- raw %} | ||
left join | ||
{% endraw -%} {{ ASPECTS_EVENT_SINK_DATABASE }}.course_names{%- raw %} as names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be a raw statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
openedx/openedx-aspects#238
openedx/openedx-aspects#240