feat: New Course Comparison Dashboard #938
Conversation
| color_pn: false | ||
| column_config: | ||
| active_count: | ||
| columnWidth: 200 |
There was a problem hiding this comment.
These aren't usually present, and seem to keep the columns from resizing when the screen is smaller. Any idea why they're here?
There was a problem hiding this comment.
yes, that was a conscious decision to prevent the 'tags' column from taking over the whole space and squishing the rest of the columns together
There was a problem hiding this comment.
Will "tags" wrap if we put spaces after the commas?
There was a problem hiding this comment.
it will, but if we dont specify the width for the other columns, itll still push all the columns to the left
There was a problem hiding this comment.
Hmm yeah I see.
@Ian2012 can we get the course comparison dashboard embedded on the sandbox site?
@crathbun428 do we have any guidance for the resolutions / page sizes we want to support?
I know we're not currently worrying about mobile, but I think we may need to adjust the sizes to make things fit reasonably on, say, a laptop screen when embedded. Does that sound fair?
There was a problem hiding this comment.
This does sound fair - I did not think about this, but can come up with some requirements for this ASAP.
There was a problem hiding this comment.
For sure, I think this is non-blocking for this PR and we can clean up the specific sizes later.
...emplates/aspects/build/aspects-superset/openedx-assets/assets/charts/Course_Info_ccdd7d.yaml
Show resolved
Hide resolved
...emplates/aspects/build/aspects-superset/openedx-assets/assets/charts/Course_Info_ccdd7d.yaml
Show resolved
Hide resolved
Closes
openedx/openedx-aspects#238
openedx/openedx-aspects#240