feat: Remove unused aspects assets on import #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraburns1
force-pushed
the
remove_old_assets
branch
from
2565988
to
6105f5c
Compare
bmtcril
reviewed
Sep 25, 2024
bmtcril
reviewed
Sep 26, 2024
Ian2012
reviewed
Sep 26, 2024
tutoraspects/templates/aspects/apps/superset/pythonpath/create_assets_utils.py
Outdated
Show resolved
Hide resolved
bmtcril
reviewed
Sep 26, 2024
Ian2012
reviewed
Oct 1, 2024
tutoraspects/templates/aspects/apps/superset/pythonpath/aspects_asset_list.yaml
Outdated
Show resolved
Hide resolved
Ian2012
reviewed
Oct 1, 2024
Comment on lines
60
to
62
| for id in id_list: | ||
| tag_command = DeleteTaggedObjectCommand(OBJECT_TYPES[asset_type], id) | ||
| tag_command.run() |
There was a problem hiding this comment.
This is not necessary as per Superset 4.0.2, and on Superset 4.1.0 this should happen automatically by the backend
There was a problem hiding this comment.
It does happen automatically, but if there are multiple tag rows per object (which there are locally at least) then it fails. I created an issue in the superset repo
There was a problem hiding this comment.
FYI - this will be fixed in the 4.1 superset release so we need to keep this code in for now
Ian2012
reviewed
Oct 1, 2024
...tes/aspects/build/aspects-superset/openedx-assets/assets/charts/Video_Engagement_8b0535.yaml
Outdated
Show resolved
Hide resolved
bmtcril
reviewed
Oct 2, 2024
saraburns1
changed the title
saraburns1
force-pushed
the
remove_old_assets
branch
from
499375d
to
fe08281
Compare
saraburns1
changed the title
bmtcril
reviewed
Oct 3, 2024
tutoraspects/templates/aspects/apps/superset/pythonpath/create_assets.py
Outdated
Show resolved
Hide resolved
bmtcril
approved these changes
Oct 4, 2024
Ian2012
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #370
create_assets.py- run during init and import-assetswrite to yaml file every uuid and it's translated asset uuids
delete_assets.py- called within create_assetsfor each uuid in aspects_asset_list 'unused' and their corresponding translated uuids, DELETE assets from superset db
delete_aspects_unused_assets.py- run during 'import_superset_zip' and 'check_superset_assets'if chart/dataset is not used AND is in aspects_asset_list under 'unused', DELETE yaml file
if chart/dataset is not used (ignoring any uuid listed under 'ignored' in aspects_asset_list.yaml) print warning about potential unused assets
Remove duplicate name check - not needed anymore since we append uuid to filename