-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove Transifex calls for FC-0012 #352
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
602d8b0
to
e428748
Compare
@OmarIthawi Thank you for this contribution! Let us know when the changes are ready for review. |
@itsjeyd thanks! We'll let you know once it's ready, but it'll take a while. This pull request will wait until deprecation notice has been communicated properly. There will be a total of 40 other similar pull request grouped into one issue: |
@OmarIthawi Oh wow, 40 PRs! 😅 Thanks for the update, that's good to know. |
Hey @OmarIthawi, it's been a while so I wanted to check in and see if you had any updates about this PR (and the batch of related ones that you mentioned above)? |
Not yet @itsjeyd. This deprecation process will likely to be done after Redwood. We don't have a specific timeline for merging those pull requests given the mandatory upfront announcements we'd need to send the community and 2U: |
1db468c
to
2195e80
Compare
@itsjeyd this pull request is finally ready, and only needs coordination with the community. It's likely to be merged after Redwood with all other pull requests listed in:
|
Sounds good @OmarIthawi, thanks for the update! |
@mphilbrick211 I went ahead and added CC @OmarIthawi |
Thank you, @itsjeyd! |
@brian-smith-tcril @timmc-edx @itsjeyd it's finally ready for merge :) |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Breaking change!
This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.
Changes
tx pull
andtx push
commands from the XBlock to let Open edX manage it..po
or.mo
files will be committed into the repos.Makefile
targets and configuration files.Merge timeline
This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.
The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.
Keep this pull request as a draft to prevent accidental merge.
Pre-merge checklist
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.