Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove Transifex calls for FC-0012 #352

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Sep 26, 2023

Breaking change!

This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.

Changes

  • Removes direct use of tx pull and tx push commands from the XBlock to let Open edX manage it.
  • Remove source and language translations from the repositories, hence no .po or .mo files will be committed into the repos.
  • Remove Transifex related Makefile targets and configuration files.
  • Use the OEP-58 JavaScript translations from the Open edX platform

Merge timeline

This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.

The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.

Keep this pull request as a draft to prevent accidental merge.

Pre-merge checklist

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U labels Sep 26, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 26, 2023

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Oct 10, 2023
@OmarIthawi OmarIthawi changed the title feat!: remove Transifex calls for OEP-58 feat!: remove Transifex calls for FC-0012 Oct 13, 2023
@itsjeyd
Copy link
Contributor

itsjeyd commented Oct 17, 2023

@OmarIthawi Thank you for this contribution! Let us know when the changes are ready for review.

@OmarIthawi
Copy link
Member Author

OmarIthawi commented Oct 17, 2023

@itsjeyd thanks! We'll let you know once it's ready, but it'll take a while.

This pull request will wait until deprecation notice has been communicated properly. There will be a total of 40 other similar pull request grouped into one issue:

@itsjeyd
Copy link
Contributor

itsjeyd commented Oct 18, 2023

@OmarIthawi Oh wow, 40 PRs! 😅 Thanks for the update, that's good to know.

@itsjeyd itsjeyd added blocked by other work PR cannot be finished until other work is complete and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Nov 2, 2023
@itsjeyd
Copy link
Contributor

itsjeyd commented Jan 12, 2024

Hey @OmarIthawi, it's been a while so I wanted to check in and see if you had any updates about this PR (and the batch of related ones that you mentioned above)?

@OmarIthawi
Copy link
Member Author

Not yet @itsjeyd. This deprecation process will likely to be done after Redwood. We don't have a specific timeline for merging those pull requests given the mandatory upfront announcements we'd need to send the community and 2U:

@OmarIthawi OmarIthawi force-pushed the depr-tx branch 2 times, most recently from 1db468c to 2195e80 Compare January 17, 2024 19:57
@OmarIthawi
Copy link
Member Author

@itsjeyd this pull request is finally ready, and only needs coordination with the community.

It's likely to be merged after Redwood with all other pull requests listed in:

@brian-smith-tcril will be leading the merge and deprecation process.

@itsjeyd
Copy link
Contributor

itsjeyd commented Jan 18, 2024

Sounds good @OmarIthawi, thanks for the update!

@itsjeyd
Copy link
Contributor

itsjeyd commented Jan 18, 2024

@mphilbrick211 I went ahead and added waiting for Redwood to last PM check notes for all the PRs listed in openedx/wg-translations#20, as well as openedx/frontend-app-support-tools#361.

CC @OmarIthawi

@mphilbrick211
Copy link

Thank you, @itsjeyd!

@OmarIthawi OmarIthawi marked this pull request as ready for review March 12, 2024 12:00
@OmarIthawi
Copy link
Member Author

@brian-smith-tcril @timmc-edx @itsjeyd it's finally ready for merge :)

@brian-smith-tcril brian-smith-tcril merged commit 7a7e8d0 into openedx:master Mar 18, 2024
7 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants