Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Python 3.11 and 3.12 support, drop Django 3.2 #383

Merged
merged 4 commits into from
Apr 17, 2024
Merged

feat: add Python 3.11 and 3.12 support, drop Django 3.2 #383

merged 4 commits into from
Apr 17, 2024

Conversation

edx-requirements-bot
Copy link
Contributor

@edx-requirements-bot edx-requirements-bot commented Feb 23, 2024 •
edited by Agrendalath
Loading

For the details, check the issue openedx/public-engineering#233

Resolves #398.

Agrendalath
Agrendalath reviewed Feb 23, 2024
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
@Agrendalath
Copy link
Member

@awais786, this breaks compatibility with Quince, so let's merge it as 4.1.0 after #352.

@awais786 awais786 force-pushed the jenkins/add-python312-support-1b3f20d branch 2 times, most recently from 987dff2 to 6a2ac95 Compare March 19, 2024 09:48
@UsamaSadiq UsamaSadiq force-pushed the jenkins/add-python312-support-1b3f20d branch from cd88257 to b427c6d Compare March 20, 2024 09:38
@UsamaSadiq UsamaSadiq marked this pull request as ready for review March 20, 2024 09:41
Agrendalath
Agrendalath requested changes Mar 20, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
drag_and_drop_v2/drag_and_drop_v2.py Outdated Show resolved Hide resolved
pylintrc_tweaks Outdated Show resolved Hide resolved
Agrendalath
Agrendalath reviewed Mar 20, 2024
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
@UsamaSadiq UsamaSadiq force-pushed the jenkins/add-python312-support-1b3f20d branch 3 times, most recently from c652d48 to 73ab5d8 Compare April 5, 2024 15:42
@Agrendalath Agrendalath force-pushed the jenkins/add-python312-support-1b3f20d branch from 4237ed8 to 56aa7c4 Compare April 17, 2024 14:04
@Agrendalath Agrendalath force-pushed the jenkins/add-python312-support-1b3f20d branch from 56aa7c4 to 89bd1eb Compare April 17, 2024 14:12
@Agrendalath Agrendalath changed the title feat: add python 3.12 support feat: add Python 3.11 and 3.12 support, drop Django 3.2 Apr 17, 2024
Agrendalath
Agrendalath approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the CI is passing; edx-platform does not use newer Python versions yet
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a

@Agrendalath Agrendalath merged commit 9d98675 into master Apr 17, 2024
9 checks passed
@Agrendalath Agrendalath deleted the jenkins/add-python312-support-1b3f20d branch April 17, 2024 14:21
This was referenced Apr 17, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agrendalath Agrendalath Agrendalath approved these changes

@UsamaSadiq UsamaSadiq Awaiting requested review from UsamaSadiq

Assignees

@Agrendalath Agrendalath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test xblock-drag-and-drop-v2 on Python 3.11
3 participants
@edx-requirements-bot @Agrendalath @UsamaSadiq