Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix quality CI checks #402

Merged
merged 2 commits into from
May 17, 2024
Merged

build: fix quality CI checks #402

merged 2 commits into from
May 17, 2024

Conversation

Agrendalath
Copy link
Member

@Agrendalath Agrendalath commented Apr 17, 2024 •
edited
Loading

This

  1. Fixes the toxenv for quality checks added in feat: add Python 3.11 and 3.12 support, drop Django 3.2 #383.
  2. Updates pylint (and linting) to work with Python 3.11 and 3.12.

@Agrendalath Agrendalath self-assigned this Apr 17, 2024
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 17, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Agrendalath! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

1 similar comment
@openedx-webhooks
Copy link

Thanks for the pull request, @Agrendalath! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Agrendalath Agrendalath force-pushed the agrendalath/fix-quality-ci branch 2 times, most recently from e99ccaf to 4d81018 Compare April 17, 2024 15:24
@Agrendalath
Copy link
Member Author

@feanil, would you mind doing a quick review here? I specified incorrect toxenv for quality checks in in #383.

@Agrendalath Agrendalath requested a review from feanil April 17, 2024 15:24
@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Apr 22, 2024
feanil
feanil approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Side note: It would be good to drop six in the future since it's only here for python 2/3 compatibility.

@Agrendalath Agrendalath merged commit c415671 into master May 17, 2024
11 checks passed
@Agrendalath Agrendalath deleted the agrendalath/fix-quality-ci branch May 17, 2024 20:28
@openedx-webhooks
Copy link

@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil approved these changes

Assignees

@Agrendalath Agrendalath

Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Agrendalath @openedx-webhooks @feanil @itsjeyd