[xqueue-watcher] add python 3.11 and 3.12 support #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 88.42% 88.44% +0.02%
==========================================
Files 6 6
Lines 475 476 +1
==========================================
+ Hits 420 421 +1
Misses 55 55 ☔ View full report in Codecov by Sentry. |
The import in `grader.py` was just not being used so I dropped it. In jailedgrader.py I replaced the implementation with the sourcefile loader from importlib which is still around. The `imp` module is deprecated and was removed in Python 3.12 With these changes the code is compatible with Python 3.8 and 3.12.
feanil
force-pushed
the
jenkins/add-python312-support-180d120
branch
from
55a38ff
to
dc93288
Compare
feanil
changed the title
kdmccormick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the details, check the issue openedx/public-engineering#233