Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: install pkg-config for PyMySQL compatibility #894

Merged
merged 2 commits into from
Jul 6, 2023
Merged

chore: install pkg-config for PyMySQL compatibility #894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
177e91c
chore: install pkg-config for PyMySQL compatibility
leangseu-edx Jul 6, 2023
f9480e5
chore: add noninteractive option to allow the image to build
leangseu-edx Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ FROM ubuntu:focal as app
# System requirements

RUN apt-get update && \
apt-get upgrade -qy && apt-get install language-pack-en locales git \
python3.8-dev python3-virtualenv libmysqlclient-dev libssl-dev build-essential wget unzip -qy && \
apt-get upgrade -qy && DEBIAN_FRONTEND=noninteractive apt-get install language-pack-en locales git \
python3.8-dev python3-virtualenv libmysqlclient-dev libssl-dev build-essential pkg-config wget unzip -qy && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding a comment to explain what these dependencies are for.

Suggested change
python3.8-dev python3-virtualenv libmysqlclient-dev libssl-dev build-essential pkg-config wget unzip -qy && \
python3.8-dev python3-virtualenv \
# mysqlclient build dependencies
libmysqlclient-dev libssl-dev build-essential pkg-config \
wget unzip -qy && \

rm -rf /var/lib/apt/lists/*

# Python is Python3.
Expand Down
Loading