Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added support for django42 #900

Merged
merged 5 commits into from
Sep 25, 2023
Merged

fix: Added support for django42 #900

merged 5 commits into from
Sep 25, 2023

Conversation

zubairshakoorarbisoft
Copy link
Contributor

Issue: #898

UsamaSadiq
UsamaSadiq reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also run github ci moderniser to start running tests with Django 4.2 as well.

@zubairshakoorarbisoft
Copy link
Contributor Author

Let's also run github ci moderniser to start running tests with Django 4.2 as well.

Let's also run github ci moderniser to start running tests with Django 4.2 as well.

@UsamaSadiq done!

iamsobanjaved
iamsobanjaved reviewed Sep 20, 2023
View reviewed changes
.github/workflows/ci.yml Outdated
python-version: [3.8]
db-version: ['mysql57', 'mysql80']
db-version: ['mysql80']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of dropping mysql57 altogether from tests, you need to do this: https://github.com/openedx/edx-platform/pull/33144/files#diff-52157910c28bbdd89808e961700cb0f625915134df2bb6f1f403c79cda7dee34R26-R28

tox.ini Outdated Show resolved Hide resolved
@iamsobanjaved iamsobanjaved linked an issue Sep 25, 2023 that may be closed by this pull request
Add Django 4.2 in CI in xqueue #898
Closed
@iamsobanjaved iamsobanjaved merged commit b96fc82 into master Sep 25, 2023
8 checks passed
@iamsobanjaved iamsobanjaved deleted the zshkoor/django42-support branch September 25, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamsobanjaved iamsobanjaved iamsobanjaved approved these changes

@UsamaSadiq UsamaSadiq Awaiting requested review from UsamaSadiq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Django 4.2 in CI in xqueue
3 participants
@zubairshakoorarbisoft @UsamaSadiq @iamsobanjaved