Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/restructure time series #236

Merged
merged 208 commits into from
Jul 21, 2022
Merged

Features/restructure time series #236

merged 208 commits into from
Jul 21, 2022

Conversation

birgits
Copy link
Collaborator

@birgits birgits commented Feb 7, 2022 •
edited
Loading

List of things to do:

Adding tests and checking of RtD API documentation of new functions:

Rename

Tests

  • q_control.py:
    • get_q_sign_generator
    • get_q_sign_load
    • fixed_cosphi
  • timeseries.py:
    • set_active_power_manual
    • set_reactive_power_manual
    • _set_manual
    • set_worst_case
    • _worst_case_generators
    • _worst_case_conventional_loads
    • _worst_case_charging_points
    • _worst_case_storage_units
    • predefined_fluctuating_generators_by_technology (@birgits)
    • predefined_dispatchable_generators_by_technology (@birgits)
    • predefined_conventional_loads_by_sector (@AnyaHe)
    • predefined_charging_points_by_use_case (@AnyaHe)
    • fixed_cosphi
    • TestTimeSeriesRaw
    • TestTimeSeriesHelperFunctions
  • Add tests for time series wrapper functions in EDisGo class
    • set_time_series_manual
    • set_time_series_worst_case_analysis
    • set_time_series_active_power_predefined
    • set_time_series_reactive_power_control

Checking of newly added reactive power factors and modes in configs (@birgits)

  • charging points
  • heat pumps

Checking of newly added worst case scale factors (further improvements addressed in #267)

  • charging points
  • heat pumps

Adapt documentation (@birgits)

  • Minimum working examples in quickstart.rst
  • Section on battery storage systems in usage_details.rst
  • Add timeseries example to fundamental data structure in usage_details.rst
  • Add overview of various options to obtain/set time series

Adapt functions

  • Adapt grid reinforcement based on worst cases - e.g. there is now an LV load case and an MV load case (@khelfen)
  • aggregate_components - drop different handling of charging points?
  • add_component - allow option "default" for reactive power time series
  • integrate_component - rename (to integrate_component_based_on_geolocation) and only allow option manual when setting time series (@birgits)
  • generator_import
  • worst case only for selected components

New functions

khelfen and others added 30 commits January 19, 2022 15:13
@khelfen
changed code to match flake8/pep8 conformity
6f5d5de
@khelfen
geopandas is now part of the standard installation and therefore the …
fe7dba3 
…import was moved to the standard import
@khelfen
small bug fixes
492ccdd
@khelfen
removed unused classes in components.py
f02f20b
@khelfen
moved shapely from dev imports to standard imports
d51ce6e
@khelfen
moved aggregation functionality from edisgo.py to tools.py #226
d6645e3
@khelfen
removed some unnecessary nesting within the aggregation functionality
ce12b1c
@khelfen
made the aggregation functionality more readable
1a8a719
@khelfen
set flake8 line length to 88
df78f49
@khelfen
Added functionality to export geo referenced components from Grid obj…
857e65b 
…ects as geopandas.GeoDataFrames

* added new container class for GeoDataFrames
* added a new geopandas property in the Grids class
* added a new method in the Topology class
* added docstrings
* added simple tests
@birgits
Move reactive power control to flex_opt
fa6f048
@birgits
Introduce TimeSeriesRaw class
2d0a20c
@birgits
Merge branch 'features/heat_pump_integration' into features/restructu…
a5f58ae 
…re_time_series
@birgits
Drop old functions
e5e5700
@birgits
Change function to not use edisgo object
250af1c
@birgits
Add functions for manual mode
cf3ee52
@birgits
Add function for worst case time series of loads
fffa8b2
@birgits
Delete old code
49f410c
@birgits
Delete old code
b6c8083
@birgits
Add attribute to TimeSeriesRaw
fd0582c
@birgits
Rewrite helper functions
dd54473
@birgits
Add function to get reactive power default configs per component
0378592
@birgits
Rename feedin to feed-in
427b66a
@birgits
Change ding0 import temporarily to set type of loads
d112d18
@birgits
Add function to generate feed-in worst case time series
d9507b9
@birgits
Add storage units worst case
fc7ab93
@birgits
Add config values for charging points and heat pumps
8d007a7
@birgits
Remove charging points from pypsa_io
631dfa6
@birgits
Change charging_points_df property
97c17b0
@birgits
Add worst case for charging points
d1cbd8c
birgits added 25 commits June 27, 2022 20:51
@birgits
Add test for set_time_series_worst_case_analysis
b15698b
@birgits
Add test for set_time_series_active_power_predefined
9b0de7b
@birgits
Merge branch 'features/restructure_time_series' of github.com:openego…
65e2e76 
…/eDisGo into features/restructure_time_series
@birgits
Bugfix use selected dataframe
de5a5d2
@birgits
Adapt simultaneity factors
ee4e913
@birgits
Add documentation for various time series options
da0e567
@birgits
Add oedb link
3d7ae34
@birgits
Bug fix grid expansion costs plot without storage
64865cf
@birgits
Mark test as slow
2e4e03e
@birgits
Adapt tests to changed simultaneity factors
b30cebe
@birgits
Update docstrings
e400aae
@birgits
Use greek letter for phi
e14ffa2
@birgits
Update rtd requirements
ef180f7
@birgits
Update modules in API doc
5c17a44
@birgits
Only import shapely if environment is not readthedocs
48da598
@birgits
Add werkzeug to rtd requirements
774de73
@birgits
Add jupyterdash to rtd requirements
a43c2ab
@birgits
Change default reactive power behavior of heat pumps
8d32e8e
@birgits
Minor docstring changes
326f9b5
@birgits
Remove pypsa_io check integrity function
08d3721
@birgits
Remove check from time series integrity check
8ab5029
@birgits
Add checks to topology check integrity
f971b0a
@birgits
Raise warning instead of error
1851169
@birgits
Fix check integrity tests
41d1ab5
@birgits
Merge branch 'features/heat_pump_integration' into features/restructu…
d7e0e5a 
…re_time_series
@birgits birgits marked this pull request as ready for review July 21, 2022 15:44
@birgits birgits merged commit dde7668 into features/heat_pump_integration Jul 21, 2022
@birgits birgits mentioned this pull request Jul 22, 2022
Merged
9 tasks
@birgits birgits deleted the features/restructure_time_series branch March 6, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@birgits birgits

@khelfen khelfen

@AnyaHe AnyaHe

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@birgits @khelfen @AnyaHe