Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/costs calculation #396

Draft
wants to merge 53 commits into
base: dev
Choose a base branch
from
Draft

Features/costs calculation #396

wants to merge 53 commits into from

Conversation

birgits
Copy link
Collaborator

@birgits birgits commented Feb 1, 2024

Description

Adds a new function that calculates grid expansion costs from a diff of the original grid and the reinforced grid. The reason this is needed is, that costs are currently calculated using Results.equipment_changes. However, this is prone to bugs when equipment changes aren't tracked correctly.
The following needs to be done:

  • Add and test new costs function
  • Store original grid in Topology.original_grid_topology when it is loaded from ding0 - needs to be stored to and restored from csv as well
  • Add function to overwrite original grid topology

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • New and adjusted code is formatted using the pre-commit hooks
  • New and adjusted code includes type hinting now
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The Read the Docs documentation is compiling correctly
  • If new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.
  • I have added new features to the corresponding whatsnew file

…nes are removed which is not written to equipment changes
@birgits birgits changed the base branch from wp_flex_changed_reinforcement to dev April 24, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant