Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/to geopandas #415

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Bugfix/to geopandas #415

merged 8 commits into from
Aug 7, 2024

Conversation

birgits
Copy link
Collaborator

@birgits birgits commented Aug 7, 2024

Description

I was using the to_geopandas() functionality to plot our grids in QGIS and saw, that the line geometries were created in a wrong way. This is because lists were used to set up the bus0 and bus1 geometries and from them get the LineString. Lists have a random order wherefore the LineStrings ended up being between random buses. I therefore changed the code to use Series instead, so that the geometry is always matched to a specific line. In the course of that I also enabled that the function can be applied to LV grids and the entire grid topology in the Topology object.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • New and adjusted code is formatted using the pre-commit hooks
  • New and adjusted code includes type hinting now
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The Read the Docs documentation is compiling correctly
  • If new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.
  • I have added new features to the corresponding whatsnew file

@birgits birgits merged commit 5d9f4c2 into dev Aug 7, 2024
8 checks passed
@birgits birgits deleted the bugfix/to_geopandas branch September 13, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant