Features/analyse results functions #615
Conversation
|
I will review this PR, if it is ok to you @KathiEsterl |
ClaraBuettner
requested review from
CarlosEpia
and removed request for
KathiEsterl
| export_negative + import_positive - export_positive - import_negative | ||
| ) | ||
|
|
||
| return marginal_cost, invest_cost, import_costs |
There was a problem hiding this comment.
It looks like the function works well. Once system_costs_germany() is called, a tuple of 3 values is shown. Could you include in the output of this function what each of them represents?
There was a problem hiding this comment.
The returned values are already described within the docstring. Do you mean that they should be described somewhere else?
| @@ -3329,3 +3335,184 @@ def plot_heat_summary(self, t_resolution="20H", stacked=True, save_path=False): | |||
|
|
|||
| if save_path: | |||
| plt.savefig(save_path, dpi=300) | |||
|
|
|||
|
|
|||
| def shifted_energy(self, carrier, buses): | |||
There was a problem hiding this comment.
Since "self" was used as the first parameter, I tried to use the function typing etrago.shifted_energy(...), but it did not work. The function works well when it is imported directly from plot.py.
There was a problem hiding this comment.
I added this function to the object in my latest commit
I migrated some of the functions I wrote to analyze results to this eTraGo branch.
I also applied black, so it looks like some files changed a lot. But you could have a look at the other commits which do the real changes.