Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/improve code style #658

Merged
merged 37 commits into from
Sep 26, 2023
Merged

Features/improve code style #658

merged 37 commits into from
Sep 26, 2023

Conversation

ClaraBuettner
Copy link
Contributor

@ClaraBuettner ClaraBuettner commented Sep 14, 2023

Fixes #445

This branch applies black, isort and flake8 changes to (nearly) all files, with the following exception:

  • flake8 tests for "Can not use bare except" are currently excluded. I tried to fix those problems, but since I didn't know the error that could show up for all occurrences, I was not able to fix all of them. We should follow up on this, see Replace bare except statements #669
  • the plot.py is not checked yet, since there will be many changes in Feature/#532 update to plotpy #568
  • the appl.py is not checked yet, since there are many warnings concerning the overly long comments in the args

I guess none of these things prevent us from merging this branch, I just added the limitations to not forget about them.

Copy link
Contributor

@CarlosEpia CarlosEpia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this branch and it is working as expected.

@ClaraBuettner ClaraBuettner merged commit 17e3eba into dev Sep 26, 2023
6 checks passed
@ClaraBuettner ClaraBuettner deleted the features/improve-code-style branch September 26, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code style
2 participants