Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make calls to 'getMesh' use 'limitToTriangulation' rather than 'repack' #60

Merged
merged 14 commits into from
Feb 2, 2022

Conversation

p-j-smith
Copy link

Fixes #59
Note, this PR does NOT fix #55

Changes made:

  • Emit a warning if the repack argument is passed to getMesh
  • The new limitToTriangulation argument of getMesh is used instead of repack in the following files:
    • distanceBetweenPoints
    • getAllAttachedMesh
    • cutMesh
  • distanceBetweenPoints now uses getMesh with limitToTriangulation set to true, instead of calling reducepatch. This is because reducepatch also reduces the resolution of the mesh, which is not necessary here.
  • initialiseGeodesic is called in private/geodesic_new_mesh, rather than in distanceBetweenPoints or HoleCutter
  • in getMesh, if type is struct, store the face data in tr.Triangulation rather than tr.Points
  • in generateInterpData, call getMesh before repacking

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #60 (c92ae9e) into develop (e978eaa) will increase coverage by 0.83%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #60      +/-   ##
==========================================
+ Coverage     4.67%   5.51%   +0.83%     
==========================================
  Files          135     135              
  Lines         7012    7017       +5     
==========================================
+ Hits           328     387      +59     
+ Misses        6684    6630      -54     
Impacted Files Coverage Δ
HoleCutter.m 0.00% <ø> (ø)
cutMesh.m 0.00% <0.00%> (ø)
generateInterpData.m 0.00% <0.00%> (ø)
getAllAttachedMesh.m 0.00% <0.00%> (ø)
private/geodesic_delete.m 42.10% <50.00%> (+3.64%) ⬆️
distanceBetweenPoints.m 100.00% <100.00%> (ø)
getMesh.m 100.00% <100.00%> (+70.21%) ⬆️
private/geodesic_new_mesh.m 90.47% <100.00%> (+22.61%) ⬆️
private/repack.m 91.66% <100.00%> (+91.66%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e978eaa...c92ae9e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants