-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make calls to 'getMesh' use 'limitToTriangulation' rather than 'repack' #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than deprecated 'repack' argumnet.
…/geodesic_new_mesh
Rather than deprecated 'repack' argumnet.
Codecov Report
@@ Coverage Diff @@
## develop #60 +/- ##
==========================================
+ Coverage 4.67% 5.51% +0.83%
==========================================
Files 135 135
Lines 7012 7017 +5
==========================================
+ Hits 328 387 +59
+ Misses 6684 6630 -54
Continue to review full report at Codecov.
|
drsewilliams
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
Note, this PR does NOT fix #55
Changes made:
repack
argument is passed togetMesh
limitToTriangulation
argument ofgetMesh
is used instead ofrepack
in the following files:distanceBetweenPoints
getAllAttachedMesh
cutMesh
distanceBetweenPoints
now usesgetMesh
withlimitToTriangulation
set totrue
, instead of callingreducepatch
. This is becausereducepatch
also reduces the resolution of the mesh, which is not necessary here.initialiseGeodesic
is called inprivate/geodesic_new_mesh
, rather than indistanceBetweenPoints
orHoleCutter
getMesh
, iftype
isstruct
, store the face data intr.Triangulation
rather thantr.Points
generateInterpData
, callgetMesh
before repacking