Merge branch 'resolves_sonarqube_issues'

openepcis · Nov 6, 2024 · 149f12d · 149f12d
2 parents b0e0bbc + cfda4ee
commit 149f12d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/.github/workflows/maven-cli.yml b/.github/workflows/maven-cli.yml
@@ -25,12 +25,13 @@ jobs:
 
       - id: run_sonarqube
         name: sonarqube
+        env:
+          SONAR_TOKEN: ${{ secrets.CG_SONAR_HOST_URL }}
         run: |
           mvn \
             -s .mvn/settings.xml \
             --no-transfer-progress \
             --batch-mode \
             -Pcoverage \
-            -Dsonar.host.url=${{ secrets.CG_SONAR_HOST_URL }} \
-            -Dsonar.login=${{ secrets.CG_SONAR_LOGIN }} \
+            -Psonar \
             clean verify sonar:sonar
diff --git a/.mvn/settings.xml b/.mvn/settings.xml
@@ -24,4 +24,16 @@
             <password>${env.OPENEPCIS_OSSRH_PASSWORD}</password>
         </server>
     </servers>
+    <profiles>
+        <profile>
+            <id>sonar</id>
+            <activation>
+                <activeByDefault>true</activeByDefault>
+            </activation>
+            <properties>
+                <sonar.host.url>https://sonar.company-group.com</sonar.host.url>
+                <sonar.login>${env.SONAR_TOKEN}</sonar.login>
+            </properties>
+        </profile>
+    </profiles>
 </settings>