-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: install psc-package
via a NPM script
#3386
Merged
edalex-ian
merged 6 commits into
openequella:develop
from
PenghaiZhang:feature/update-npm-script
Sep 13, 2021
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
00d56f7
chore: install `psc-package` via a NPM script
PenghaiZhang 170c62f
build: installing node via `.nvmrc` in GHA builds.
PenghaiZhang f8bee4a
chore: pin the version of IntegTester's dependencies
PenghaiZhang 6a44499
chore: remove the redundant node setup in GHA yaml file
PenghaiZhang 56aa95a
chore: copy the psc-package executable to node module bin folder
PenghaiZhang ad55023
chore: delete the redundant `psc-package.exe`
PenghaiZhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,4 @@ | |
/.psc* | ||
/.purs* | ||
/.psa* | ||
/psc-package |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
/* | ||
* Licensed to The Apereo Foundation under one or more contributor license | ||
* agreements. See the NOTICE file distributed with this work for additional | ||
* information regarding copyright ownership. | ||
* | ||
* The Apereo Foundation licenses this file to you under the Apache License, | ||
* Version 2.0, (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
const https = require("follow-redirects").https; | ||
const tar = require("tar"); | ||
const shell = require("shelljs"); | ||
|
||
https.get( | ||
`https://github.com/purescript/psc-package/releases/download/v0.6.2/linux64.tar.gz`, | ||
(res) => { | ||
return res.pipe( | ||
tar.x().on("finish", () => { | ||
if (shell.test("-f", "./psc-package/psc-package")) { | ||
shell.cp("./psc-package/psc-package", "./node_modules/.bin/"); | ||
shell.mv( | ||
"./psc-package/psc-package", | ||
"./psc-package/psc-package.exe" | ||
); | ||
} | ||
}) | ||
); | ||
} | ||
); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you know that
setup-node
comes with caching now?Read the readme and learn more here: https://github.com/actions/setup-node#caching-packages-dependencies.
By the way
setup-java
comes with caching as well, but I don't know much about Java, so won't apply any suggestions here.https://github.com/actions/setup-java#caching-packages-dependencies
Also check if the version of
setup-java
you're using comes with the caching capability before you turn it on for Java.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a nice new feature. Thanks for letting us know. We'll have a look and see what we might be able to refactor, because the build definition sure is long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edalex-ian Do you want me to make an issue with the same text? That way I'm not blocking this PR, and you can track the issue that way, and follow up when you have time to work on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd be great thanks @HonkingGoose. 👍
I'll go and merge this in the meantime. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See issue #3390 for the "feature request".