chore(deps): update dependency org.seleniumhq.selenium:selenium-java to v4 #3522

renovate · 2021-10-26T06:30:46Z

This PR contains the following updates:

Package	Update	Change
org.seleniumhq.selenium:selenium-java (source)	major	`3.141.59` -> `4.26.0`

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

SeleniumHQ/selenium (org.seleniumhq.selenium:selenium-java)

`v4.26.0`

`v4.25.0`

`v4.24.0`

`v4.23.0`

`v4.22.0`

`v4.21.0`

`v4.20.0`

`v4.19.0`

`v4.18.1`

`v4.18.0`

`v4.17.0`

`v4.16.0`

`v4.15.0`

`v4.14.0`

`v4.13.0`

`v4.12.0`

`v4.11.0`

`v4.10.0`

`v4.9.1`

`v4.9.0`

`v4.8.2`

`v4.8.1`

`v4.8.0`

`v4.7.1`

`v4.7.0`

`v4.6.0`

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

edalex-ian · 2021-10-26T23:03:35Z

Hmm, well that could've been worse. Seems compilation has just failed on a few (seemingly) internal classes being used:

Hopefully if we find a suitable alternative then we might get compilation to pass to see how execution is impacted.

…to v4

WrapsElement moved out of 'internal' as per SeleniumHQ/selenium#6881

Newer Selenium uses Duration rather than int (seconds) for waits and timeouts.

This function has been removed. Indeed, FirefoxBinary has been deprecated and we're meant to move to FirefoxOptions.

edalex-ian · 2024-11-05T05:00:47Z

Okay, so with all the test runs we're having I've gone and addressed all the issues.

I've run a few test suites locally and they run. I've also tried some of the flaky ones and they also continue to sometimes flake. But things seem to run faster, and I believe we get better error messages.

Let's see what happens.

Considering everything on tests is flaking at the moment, if this doesn't make anything materially worse I suggest we merge it in.

renovate · 2024-11-05T05:12:35Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

edalex-ian · 2024-11-05T22:36:05Z

So the good news is, everything still works as well as it did before. But, the bad news is, everything still works as well as it did before.

That is, the same tests are still flaking like they always did. But, at least the upgrade worked - in that it didn't make anything worse.

Let's get this reviewed and merged an then we can go from there.

edalex-ian · 2024-11-05T22:38:59Z

autotest/Tests/src/main/java/com/tle/webtests/framework/setup/SyncToLocalServer.java

@@ -175,7 +173,6 @@ private FirefoxDriver getDriver() {
    } else {
      binary = new FirefoxBinary();
    }
-    binary.setTimeout(SECONDS.toMillis(120));


setTimeout is no longer available. And we shouldn't even be using FirefoxBinary any more. The commit for this is 792b61c

edalex-ian · 2024-11-05T22:40:37Z

autotest/Tests/src/main/java/com/tle/webtests/framework/StandardDriverFactory.java

@@ -142,7 +140,6 @@ public WebDriver getDriver(Class<?> clazz) throws IOException {
        } else {
          binary = new FirefoxBinary();
        }
-        binary.setTimeout(SECONDS.toMillis(120));


setTimeout is no longer available. And we shouldn't even be using FirefoxBinary any more. The commit for this is 792b61c

edalex-yinzi

LGTM, just one minor suggestion.

autotest/Tests/src/main/java/com/tle/webtests/pageobject/institution/StatusPage.java

…umhq.selenium-selenium-java-4.x" This reverts commit a72cb85, reversing changes made to 4221008.

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from e6dc225 to e94c97c Compare November 23, 2021 13:44

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from e94c97c to b7ed99c Compare December 17, 2021 23:39

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch 3 times, most recently from cd6cf31 to 478d694 Compare January 30, 2022 22:14

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 478d694 to 0e6eb55 Compare February 16, 2022 10:12

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 0e6eb55 to 90f66b0 Compare March 28, 2022 01:57

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 90f66b0 to f624192 Compare April 27, 2022 14:23

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch 2 times, most recently from 7a28b99 to a3260a6 Compare May 31, 2022 11:28

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from a3260a6 to fbfe3a7 Compare June 9, 2022 16:26

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from fbfe3a7 to 9202569 Compare June 24, 2022 03:20

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 9202569 to a32ebee Compare August 9, 2022 11:25

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from a32ebee to 99d27d6 Compare September 29, 2022 00:18

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch 3 times, most recently from 8ebbea8 to 668dbf1 Compare October 24, 2022 13:49

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 668dbf1 to da17d1c Compare November 4, 2022 13:14

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch 2 times, most recently from e637aae to cdb2ea4 Compare December 7, 2022 19:35

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from cdb2ea4 to 3ed7215 Compare December 13, 2022 12:43

renovate bot changed the title ~~chore(deps): update dependency org.seleniumhq.selenium:selenium-java to v4~~ Update dependency org.seleniumhq.selenium:selenium-java to v4 Dec 17, 2022

renovate bot changed the title ~~Update dependency org.seleniumhq.selenium:selenium-java to v4~~ chore(deps): update dependency org.seleniumhq.selenium:selenium-java to v4 Dec 17, 2022

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 3ed7215 to 34c2ded Compare January 23, 2023 16:16

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 34c2ded to e474179 Compare February 17, 2023 22:41

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch 2 times, most recently from 069c054 to 1165ebc Compare March 27, 2023 02:36

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 1165ebc to 3b5303c Compare April 30, 2023 07:52

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 3b5303c to 0368034 Compare May 8, 2023 13:41

edalex-ian added the help wanted label Mar 5, 2024

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch 2 times, most recently from a74b973 to 3d43c0e Compare March 29, 2024 09:37

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 3d43c0e to b25e29f Compare April 24, 2024 21:50

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from b25e29f to c9c34d4 Compare May 16, 2024 14:17

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from c9c34d4 to 999b5bf Compare June 4, 2024 11:58

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 999b5bf to f33ae75 Compare June 20, 2024 22:31

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from f33ae75 to bd7041d Compare July 4, 2024 00:01

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch 2 times, most recently from eb1d801 to 9c83bdc Compare July 19, 2024 11:38

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 9c83bdc to 1a2287e Compare August 9, 2024 15:08

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from 1a2287e to c0087ba Compare August 28, 2024 12:27

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from c0087ba to c9f09a0 Compare September 20, 2024 19:44

chore(deps): update dependency org.seleniumhq.selenium:selenium-java …

86199da

…to v4

renovate bot force-pushed the renovate/org.seleniumhq.selenium-selenium-java-4.x branch from c9f09a0 to 86199da Compare October 30, 2024 13:49

edalex-ian added 3 commits November 5, 2024 15:07

test(Selenium): update WrapsElement import

5b492a5

WrapsElement moved out of 'internal' as per SeleniumHQ/selenium#6881

test(Selenium): move to using Duration

eaeac17

Newer Selenium uses Duration rather than int (seconds) for waits and timeouts.

test(Selenium): remove calls to FirefoxBinary::setTimeout

792b61c

This function has been removed. Indeed, FirefoxBinary has been deprecated and we're meant to move to FirefoxOptions.

edalex-ian requested a review from edalex-yinzi November 5, 2024 22:36

edalex-ian self-assigned this Nov 5, 2024

edalex-ian removed the help wanted label Nov 5, 2024

edalex-ian reviewed Nov 5, 2024

View reviewed changes

edalex-yinzi approved these changes Nov 6, 2024

View reviewed changes

autotest/Tests/src/main/java/com/tle/webtests/pageobject/institution/StatusPage.java Show resolved Hide resolved

edalex-ian merged commit a72cb85 into develop Nov 6, 2024
3 of 6 checks passed

edalex-ian deleted the renovate/org.seleniumhq.selenium-selenium-java-4.x branch November 6, 2024 02:57

PenghaiZhang pushed a commit that referenced this pull request Dec 20, 2024

Revert "Merge pull request #3522 from openequella/renovate/org.seleni…

eca283e

…umhq.selenium-selenium-java-4.x" This reverts commit a72cb85, reversing changes made to 4221008.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update dependency org.seleniumhq.selenium:selenium-java to v4 #3522

chore(deps): update dependency org.seleniumhq.selenium:selenium-java to v4 #3522

renovate bot commented Oct 26, 2021 •

edited

Loading

edalex-ian commented Oct 26, 2021

edalex-ian commented Nov 5, 2024

renovate bot commented Nov 5, 2024

edalex-ian commented Nov 5, 2024

edalex-ian Nov 5, 2024

edalex-ian Nov 5, 2024

edalex-yinzi left a comment

chore(deps): update dependency org.seleniumhq.selenium:selenium-java to v4 #3522

chore(deps): update dependency org.seleniumhq.selenium:selenium-java to v4 #3522

Conversation

renovate bot commented Oct 26, 2021 • edited Loading

Release Notes

Configuration

edalex-ian commented Oct 26, 2021

edalex-ian commented Nov 5, 2024

renovate bot commented Nov 5, 2024

Edited/Blocked Notification

edalex-ian commented Nov 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edalex-yinzi left a comment

Choose a reason for hiding this comment

renovate bot commented Oct 26, 2021 •

edited

Loading