Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #62

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Update README.md #62

merged 1 commit into from
Jun 4, 2019

Conversation

retgits
Copy link
Contributor

@retgits retgits commented Jun 4, 2019

Update the README.md file with badges as mentioned in #61

Description

Added badges similar to the openfaas/faas-netes repository

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Readme change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek derek bot added the new-contributor label Jun 4, 2019
@derek
Copy link

derek bot commented Jun 4, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Jun 4, 2019
Update with badges

Signed-off-by: retgits <[email protected]>
@derek derek bot removed the no-dco label Jun 4, 2019
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 1263e66 into openfaas:master Jun 4, 2019
@alexellis
Copy link
Member

Thank you Leon, so fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants