Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#64 3.0.x #121

Open
wants to merge 4 commits into
base: 3.0.x
Choose a base branch
from
Open

Feature/#64 3.0.x #121

wants to merge 4 commits into from

Conversation

rutiolma
Copy link
Collaborator

@rutiolma rutiolma commented Jul 4, 2024

Can you review this alternative implementation?
It reverts the previous merge for issue #64 and proposes an alternative implementation to use twig_real_content, keeping the "has_[region]" function.

Copy link
Collaborator

@smillart smillart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does everybody agree with this implementation? For now, I just reviewed the code and I don't think this works as expected. Are the body_classes variable contains the expected CSS classes, which are supposed to be outputted on the <body> element?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How this html.html.twig template can access the has_[region] variables if those are created from the kiso_preprocess_page() function only?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants