Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify err messages in check function #405

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

Siddhant-K-code
Copy link
Contributor

@Siddhant-K-code Siddhant-K-code commented Oct 14, 2024

Description

This pull request updates the error messages in the check function to provide more informative and concise error messages. The "failed to check" error message has been changed to "check failed" to better reflect the actual error.

Updated error message would look like:

Error: check failed: <error_message>

Actual Example:

Error: check failed: Post "http://localhost:8080/stores/01H4P8Z95KTXXEP6Z03T75Q984/check": dial tcp [::1]:8080: connect: connection refused

References

fixes #404

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

@Siddhant-K-code Siddhant-K-code requested a review from a team as a code owner October 14, 2024 11:10
cmd/query/check.go Outdated Show resolved Hide resolved
@Siddhant-K-code Siddhant-K-code changed the title Update error messages in check function simplify err messages in check function Oct 15, 2024
Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewanharris ewanharris added this pull request to the merge queue Oct 16, 2024
Merged via the queue into openfga:main with commit 4156d21 Oct 16, 2024
15 checks passed
@Siddhant-K-code Siddhant-K-code deleted the fix/404 branch October 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent error message when Check fails
2 participants