Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not create new http client on every request #52

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix: do not create new http client on every request #52

merged 1 commit into from
Jan 26, 2024

Conversation

jimmyjames
Copy link
Contributor

@jimmyjames jimmyjames commented Jan 26, 2024 •
edited
Loading

don't create a new Http client on every request.

Description

generated from openfga/sdk-generator#287

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jimmyjames jimmyjames requested a review from a team as a code owner January 26, 2024 19:40
@rhamzeh rhamzeh added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 1ad6a34 Jan 26, 2024
10 of 11 checks passed
@rhamzeh rhamzeh deleted the fix/http-client branch January 26, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A new thread is being created for every OpenFgaClient call
2 participants
@jimmyjames @rhamzeh