feat(java): Allow overrides of Configuration #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rhamzeh
reviewed
Aug 22, 2023
booniepepper
force-pushed
the
feat/java-sdk-config-overrides
branch
from
211bf6f
to
05ed244
Compare
adriantam
reviewed
Aug 23, 2023
| * @param storeId (required) | ||
| * @param body (required) | ||
| * @param configurationOverride Override the {@link Configuration} this OpenFgaApi was constructed with | ||
| * @return CompletableFuture<CheckResponse> |
There was a problem hiding this comment.
Javadocs use html escapes so < is an escaped < -- it also allows some html tags like <code> but the rules are not exactly the same as HTML. There are also some custom {@<ident> <content>} Javadoc tags.
This renders correctly for the viewer:
But taking a look at the JavaDocs, there's also a mess of unrendered markdown in some descriptions
Maybe it's worth an issue to update all the things. Maybe it's as simple as pandoc from commonmark to html for the descriptions, and doing some html unescaping. This is in a lot of the generated files
There was a problem hiding this comment.
Opened this issue, I think I'd rather it was all addressed together, and avoid letting it get inconsistent right now
booniepepper
force-pushed
the
feat/java-sdk
branch
from
958df2f
to
b31f60e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most changes here can be seen in OpenFgaApi.java
References
Generated by openfga/sdk-generator#189
Review Checklist
main