Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: handle gradle action deprecations #82

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

ewanharris
Copy link
Member

@ewanharris ewanharris commented May 2, 2024

Description

Noticed a warning about this on the release job so figured we should switch over, it's functionally identical just renamed.

Also changes the publish step to the new way of setting up gradle and then calling the tasks as arguments is now deprecated too

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested a review from a team as a code owner May 2, 2024 14:43
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.49%. Comparing base (79bb07a) to head (083073d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #82   +/-   ##
=========================================
  Coverage     27.49%   27.49%           
  Complexity      787      787           
=========================================
  Files           159      159           
  Lines          5928     5928           
  Branches        651      651           
=========================================
  Hits           1630     1630           
  Misses         4222     4222           
  Partials         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris changed the title ci: switch to new gradle wrapper-validation action ci: handle gradle action deprecations May 2, 2024
@rhamzeh
Copy link
Member

rhamzeh commented May 2, 2024

Can we do the same to the spring-boot-starter? cc @jimmyjames

@ewanharris ewanharris added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 501bfa0 May 7, 2024
19 checks passed
@ewanharris ewanharris deleted the ci/change-gradle-action branch May 7, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants