Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements to OpenTelemetry metrics #95

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

evansims
Copy link
Member

@evansims evansims commented Jul 23, 2024

Description

This PR updates the changes made in #94 to support a number of new and overlook attributes previously not implemented, and improves clarity in the wording of descriptions. It also updates the attribute naming convention based on feedback.

References

Generated from openfga/sdk-generator#402

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansims evansims added the enhancement New feature or request label Jul 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 90.72581% with 23 lines in your changes missing coverage. Please review.

Project coverage is 30.88%. Comparing base (489ca8e) to head (f1ad4e1).

Files Patch % Lines
...ain/java/dev/openfga/sdk/telemetry/Attributes.java 73.91% 1 Missing and 11 partials ⚠️
...dev/openfga/sdk/api/client/HttpRequestAttempt.java 66.66% 5 Missing ⚠️
...v/openfga/sdk/api/configuration/Configuration.java 50.00% 2 Missing and 1 partial ⚠️
...a/sdk/api/configuration/ConfigurationOverride.java 50.00% 2 Missing ⚠️
src/main/java/dev/openfga/sdk/api/OpenFgaApi.java 99.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #95      +/-   ##
============================================
+ Coverage     29.20%   30.88%   +1.67%     
- Complexity      815      842      +27     
============================================
  Files           166      168       +2     
  Lines          6030     6185     +155     
  Branches        650      679      +29     
============================================
+ Hits           1761     1910     +149     
+ Misses         4186     4177       -9     
- Partials         83       98      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims evansims marked this pull request as ready for review July 25, 2024 04:02
@evansims evansims requested review from a team as code owners July 25, 2024 04:02
@evansims evansims force-pushed the feat/improvements-to-opentelemetry-metrics branch 2 times, most recently from d356f83 to e6789d6 Compare July 25, 2024 04:16
src/main/java/dev/openfga/sdk/telemetry/Histograms.java Outdated Show resolved Hide resolved
docs/OpenTelemetry.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/OpenTelemetry.md Outdated Show resolved Hide resolved
docs/OpenTelemetry.md Outdated Show resolved Hide resolved
docs/OpenTelemetry.md Outdated Show resolved Hide resolved
src/main/java/dev/openfga/sdk/api/OpenFgaApi.java Outdated Show resolved Hide resolved
src/main/java/dev/openfga/sdk/api/OpenFgaApi.java Outdated Show resolved Hide resolved
@evansims evansims force-pushed the feat/improvements-to-opentelemetry-metrics branch 2 times, most recently from fb4ede6 to 2871922 Compare August 7, 2024 06:46
@evansims evansims marked this pull request as draft August 7, 2024 06:55
auto-merge was automatically disabled August 7, 2024 06:55

Pull request was converted to draft

@evansims evansims force-pushed the feat/improvements-to-opentelemetry-metrics branch 2 times, most recently from 939aa6e to 229495e Compare August 9, 2024 06:03
@evansims evansims marked this pull request as ready for review August 9, 2024 06:05
@evansims evansims force-pushed the feat/improvements-to-opentelemetry-metrics branch from ee59caf to e0ec831 Compare August 13, 2024 04:52
@evansims evansims force-pushed the feat/improvements-to-opentelemetry-metrics branch from d4b9e49 to 8162946 Compare August 13, 2024 04:58
@evansims evansims requested a review from rhamzeh August 16, 2024 04:00
@evansims evansims added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit 885f48b Aug 19, 2024
19 checks passed
@evansims evansims deleted the feat/improvements-to-opentelemetry-metrics branch August 19, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants