-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improvements to OpenTelemetry metrics #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
============================================
+ Coverage 29.20% 30.88% +1.67%
- Complexity 815 842 +27
============================================
Files 166 168 +2
Lines 6030 6185 +155
Branches 650 679 +29
============================================
+ Hits 1761 1910 +149
+ Misses 4186 4177 -9
- Partials 83 98 +15 ☔ View full report in Codecov by Sentry. |
evansims
force-pushed
the
feat/improvements-to-opentelemetry-metrics
branch
2 times, most recently
from
July 25, 2024 04:16
d356f83
to
e6789d6
Compare
ewanharris
reviewed
Jul 25, 2024
rhamzeh
reviewed
Jul 30, 2024
src/main/java/dev/openfga/sdk/api/client/HttpRequestAttempt.java
Outdated
Show resolved
Hide resolved
evansims
force-pushed
the
feat/improvements-to-opentelemetry-metrics
branch
2 times, most recently
from
August 7, 2024 06:46
fb4ede6
to
2871922
Compare
auto-merge was automatically disabled
August 7, 2024 06:55
Pull request was converted to draft
4 tasks
evansims
force-pushed
the
feat/improvements-to-opentelemetry-metrics
branch
2 times, most recently
from
August 9, 2024 06:03
939aa6e
to
229495e
Compare
evansims
force-pushed
the
feat/improvements-to-opentelemetry-metrics
branch
from
August 13, 2024 04:52
ee59caf
to
e0ec831
Compare
Co-Authored-By: Ewan Harris <[email protected]>
evansims
force-pushed
the
feat/improvements-to-opentelemetry-metrics
branch
from
August 13, 2024 04:58
d4b9e49
to
8162946
Compare
ewanharris
reviewed
Aug 16, 2024
ewanharris
approved these changes
Aug 19, 2024
This was referenced Aug 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the changes made in #94 to support a number of new and overlook attributes previously not implemented, and improves clarity in the wording of descriptions. It also updates the attribute naming convention based on feedback.
References
Generated from openfga/sdk-generator#402
Review Checklist
main