-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename configuration language to modeling language #686
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some casing and branding nitpicks.
link: './configuration-language', | ||
id: './configuration-language', | ||
title: 'Modeling Language', | ||
description: 'Learning about the FGA modeling language', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In docs/content/getting-started/immutable-models.mdx we use {ProductName}
, here and in some other cases we use FGA
- which do you prefer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that Andres strongly prefers {ProductName} because it means the content can be recycled.
link: '../configuration-language', | ||
id: '../configuration-language', | ||
title: 'Modeling Language', | ||
description: 'Learn about the {ProductName} Modeling Language.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elsewhere we seem to use sentence case, but here we use title case. I think sentence case is preferred, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would pick one strategy and make it consistent everywhere, but let me know if I'm missing some nuance here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Section titles are going to be sentence case, yes. My plan is to slightly modify our current style guide for FGA purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a lot of changes but it looks like they were handled honorably!
Description
Replaces "Configuration Language" with "Modeling Language"
https://openfga.github.io/openfga.dev/pr-preview/pr-686/docs
References
Review Checklist
main