Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(go-sdk): configurable client credentials token url #275

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat(go-sdk): configurable client credentials token url #275

merged 1 commit into from
Jan 15, 2024

Conversation

le-yams
Copy link
Contributor

@le-yams le-yams commented Jan 12, 2024

Description

Make token endpoint configurable. I implemented the same way I did for the java-sdk.

References

#238

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@le-yams le-yams requested a review from a team as a code owner January 12, 2024 20:02
@rhamzeh rhamzeh mentioned this pull request Jan 15, 2024
Open
5 tasks
rhamzeh
rhamzeh approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @le-yams! ❤️

@rhamzeh rhamzeh added this pull request to the merge queue Jan 15, 2024
Merged via the queue into openfga:main with commit a1a9eec Jan 15, 2024
2 of 7 checks passed
@le-yams le-yams deleted the go/configurable_token_issuer_url branch January 17, 2024 13:51
@le-yams le-yams mentioned this pull request Jan 18, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@le-yams @rhamzeh