feat(go-sdk)!: remove StoreId from API client config #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
java-sdk test failures are not related to this change; #361 to fix |
ewanharris
previously approved these changes
May 22, 2024
[BREAKING CHANGE]
… client to send the storeId from its config
jimmyjames
force-pushed
the
remove-store-id-config
branch
from
9f422d6
to
2b5e3be
Compare
ewanharris
approved these changes
May 23, 2024
This was referenced May 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the StoreId from the API client, and instead accept the
StoreIdas a parameter. As discussed in #118, this allows for the removal of the custom patch. A follow-on PR will enable overriding theStoreIdper request as we do for theAuthorizationModelId.If using
api_open_fga.godirectly, you will now need to pass theStoreIdparameter.References
#118
Review Checklist
main