fix(java-sdk): Fix tests for assertions model changes #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ewanharris
approved these changes
May 22, 2024
|
Instead of this, a change was made to pin the OpenFGA API version: #362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the java-sdk tests for writing assertions, which was caused by the API now allowing contextual tuples to be specified on the request to create assertions.
I created #360 to update our models to support this in the SDK, but for now we're just fixing the tests.
(aside - we should look into if there's a way for the java SDK tests to not be so picky)
References
Unblocks #359 and #358
Review Checklist
main