Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(js-sdk): remove usage of patch file for handling telemetry attributes #442

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

ewanharris
Copy link
Member

Description

Removes the patch file that was originally used as a way to handle the store ID, model ID, and tuple key user metrics attributes and instead move to the following:

  • storeId - Included by the generator if there is a path parameter
  • modelId/tuple_key.user - Body (if present) is passed off to a function in TelemetryAttributes that handles creating the correct object.

References

openfga/js-sdk#172

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

@ewanharris ewanharris added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit f37bb5b Nov 4, 2024
14 checks passed
@ewanharris ewanharris deleted the refactor/remove-js-telemetry-patch branch November 4, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants