-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python-sdk): type hinting improvements #480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…lake`, and `black`
…b.com/openfga/sdk-generator into feat/python/type-hinting-improvements
1bb8221
to
920c891
Compare
rhamzeh
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a first pass at type hinting improvements I'm making to the SDK. This first pass addresses errors in the existing type hints and ensures our client models are fully typed and hinted appropriately.
This pull request adds the
mypy
static type linter to our build process and an initial configuration for it to thepyproject.toml
file. Note that there are a few commented-out flags; I intend to enable these with future passes.References
This PR is a step towards addressing openfga/python-sdk#109, but further work is required before we can call that closed.
Generates openfga/python-sdk#167
Review Checklist
main