Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python-sdk): type hinting improvements #480

Merged
merged 9 commits into from
Feb 4, 2025

Conversation

evansims
Copy link
Member

Description

This pull request is a first pass at type hinting improvements I'm making to the SDK. This first pass addresses errors in the existing type hints and ensures our client models are fully typed and hinted appropriately.

This pull request adds the mypy static type linter to our build process and an initial configuration for it to the pyproject.toml file. Note that there are a few commented-out flags; I intend to enable these with future passes.

References

This PR is a step towards addressing openfga/python-sdk#109, but further work is required before we can call that closed.

Generates openfga/python-sdk#167

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansims evansims added enhancement New feature or request python-sdk Affects the Python SDK labels Jan 30, 2025
Copy link

linux-foundation-easycla bot commented Feb 3, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@evansims evansims force-pushed the feat/python/type-hinting-improvements branch from 1bb8221 to 920c891 Compare February 3, 2025 17:03
@evansims evansims marked this pull request as ready for review February 4, 2025 01:33
@evansims evansims requested a review from a team as a code owner February 4, 2025 01:33
@evansims evansims added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit adccb71 Feb 4, 2025
14 checks passed
@evansims evansims deleted the feat/python/type-hinting-improvements branch February 4, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python-sdk Affects the Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants