-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds type for /keys endpoint #230
base: main
Are you sure you want to change the base?
Conversation
do I need to run the OpenAPI spec file after this change? @CharlesNepote |
I don't think so, because FastAPI produces the OpenAPI spec file automatically, see https://api.folksonomy.openfoodfacts.org/openapi.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but maybe @VaiTon should confirm these changes provide what he's expecting?
I don't really know how the openapi generator works, but I guess this should be sufficient to make it return a model |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
- Coverage 95.06% 94.55% -0.52%
==========================================
Files 5 5
Lines 324 367 +43
==========================================
+ Hits 308 347 +39
- Misses 16 20 +4 ☔ View full report in Codecov by Sentry. |
What
KeyStats
for/keys
endpoint