Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds type for /keys endpoint #230

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kirtanchandak
Copy link

What

  • Adds model names KeyStats for /keys endpoint

@kirtanchandak
Copy link
Author

do I need to run the OpenAPI spec file after this change? @CharlesNepote

@CharlesNepote CharlesNepote changed the title Adds type for /keys endpoint feat: Adds type for /keys endpoint Feb 28, 2025
@CharlesNepote
Copy link
Member

do I need to run the OpenAPI spec file after this change? @CharlesNepote

I don't think so, because FastAPI produces the OpenAPI spec file automatically, see https://api.folksonomy.openfoodfacts.org/openapi.json

Copy link
Member

@CharlesNepote CharlesNepote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but maybe @VaiTon should confirm these changes provide what he's expecting?

@VaiTon
Copy link
Member

VaiTon commented Feb 28, 2025

Looks good to me, but maybe @VaiTon should confirm these changes provide what he's expecting?

I don't really know how the openapi generator works, but I guess this should be sufficient to make it return a model

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (b9cda65) to head (a0a99a7).
Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   95.06%   94.55%   -0.52%     
==========================================
  Files           5        5              
  Lines         324      367      +43     
==========================================
+ Hits          308      347      +39     
- Misses         16       20       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

suchithh added a commit to suchithh/folksonomy_api that referenced this pull request Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants