Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PUT API response does not send ValidationError when expected #235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abbas-Askari
Copy link

What

Fix the issue described in #117. The API previously just sent {"detail":"next version must be equal to 2, was 1"} instead of a ValidationError. Now the endpoint first fetches the current version from db, and send a validation error back if the version is not properly incremented.

Screenshot

{
  "detail": [
    {
      "type": "value_error",
      "loc": [
        "body",
        "version"
      ],
      "msg": "Value error, version must be exactly 2",
      "input": 4
    }
  ]
}

Fixes bug(s)

@Abbas-Askari Abbas-Askari requested a review from a team as a code owner March 1, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant