Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove webpack bundling #657

Closed
wants to merge 2 commits into from
Closed

Remove webpack bundling #657

wants to merge 2 commits into from

Conversation

VaiTon
Copy link
Member

@VaiTon VaiTon commented Jul 7, 2023

What

  • AFAIK, we don't need to bundle everything in a single JS file, as the app is deployed separately from the main website.

@VaiTon VaiTon requested a review from a team as a code owner July 7, 2023 16:28
@VaiTon VaiTon mentioned this pull request Jul 7, 2023
Merged
@VaiTon
Copy link
Member Author

VaiTon commented Jul 7, 2023

@stephanegigandet @alexgarel I'm tagging you since the bundle was made to "facilitate integration in OFF main site".

@VaiTon VaiTon requested review from alexfauquette and removed request for a team, alexgarel and stephanegigandet July 7, 2023 22:04
@alexgarel
Copy link
Member

Thanks @VaiTon

I think you can remove this indeed unless @teolemon has some information I'm not aware off.

@VaiTon VaiTon closed this Jul 24, 2023
@VaiTon VaiTon deleted the remove-webpack-build branch July 25, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@alexgarel alexgarel Awaiting requested review from alexgarel

@teolemon teolemon Awaiting requested review from teolemon

Assignees

@VaiTon VaiTon

Labels
PR: needs rebase
Projects
Hunger Games (new)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VaiTon @alexgarel @alexfauquette