Fix GitHub pages deploy #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
GitHub Actions
Comment on lines
+39
to
+47
| - name: Upload artifact | ||
| uses: actions/upload-pages-artifact@v1 | ||
| with: | ||
| path: 'dist' | ||
|
|
||
| - name: Deploy to github pages 🚀 | ||
| if: github.ref == 'refs/heads/master' | ||
| uses: JamesIves/[email protected] | ||
| with: | ||
| branch: gh-pages # The branch the action should deploy to. | ||
| folder: build # The folder the action should deploy. | ||
| id: deployment | ||
| uses: actions/deploy-pages@v2 |
There was a problem hiding this comment.
I'm not sure to understand, the difference between the two
"Upload artifact" is uploading the dist folder. But then what is doing the actions/deploy-pages@v2?
There was a problem hiding this comment.
To deploy to Github pages via an action you first need to upload an artifact with a specific name and then invoke the deploy-pages action. See https://github.com/actions/deploy-pages/tree/main#usage
There was a problem hiding this comment.
Thanks for the explaination
alexfauquette
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.shscript. This fixes it.