fix: change the id from en:united-kingdom to en:uk #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for warm-cannoli-79bbb2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
teolemon
changed the title
CloCkWeRX
approved these changes
Dec 31, 2023
There was a problem hiding this comment.
Seems sensible. For identifiers, might be worth making sure they all use whatever the current https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes codes are
teolemon
reviewed
Jul 22, 2024
| if (!countryId) { | ||
| return ""; | ||
| } | ||
| const country = counties.find((item) => item.id === countryId); |
teolemon
reviewed
Jul 22, 2024
There was a problem hiding this comment.
- There's a wider issue reported by @raphael0202 at Use parameters countries= when fetching insights #1001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #740