feat: add country list in settings page, using it as default country in eco-score #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for warm-cannoli-79bbb2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Gaurav-Verma07
changed the title
| ); | ||
|
|
||
| React.useEffect(() => { | ||
| setSearchParams({ cc: selectedCountry }); | ||
| }, [selectedCountry]); | ||
| }, [selectedCountry, searchParams]); |
There was a problem hiding this comment.
I don't see why adding this dependency
Suggested change
| }, [selectedCountry, searchParams]); | |
| }, [selectedCountry]); |
There was a problem hiding this comment.
I don't see why adding this dependency
Actually it's kind of important, if you go to https://hunger.openfoodfacts.org/eco-score?cc=en%3Afrance
and click eco-score in navbar, the query parameter disappears which is not an expected behavior.
What you think?
Co-authored-by: Alexandre Fauquette <[email protected]>
Co-authored-by: Alexandre Fauquette <[email protected]>
Co-authored-by: Alexandre Fauquette <[email protected]>
Co-authored-by: Alexandre Fauquette <[email protected]>
alexfauquette
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in eco-score
What
Add country drop-down in settings page using
countries.json.Settings it as default in
eco-scorepage.Screenshot
Fixes bug(s)
Fix #887