refactor(Price add): On price add done, redirect to User Dashboard (#941

)
openfoodfacts · Oct 7, 2024 · bb9d2ff · bb9d2ff
1 parent 63ff257
commit bb9d2ff
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 42 deletions.
diff --git a/src/views/AddPriceMultiple.vue b/src/views/AddPriceMultiple.vue
@@ -304,7 +304,7 @@ export default {
         })
     },
     done() {
-      this.$router.push({ path: '/prices', query: { multipleSuccess: 'true' } })
+      this.$router.push({ path: '/dashboard', query: { multipleSuccess: 'true' } })
     }
   }
 }

diff --git a/src/views/AddPriceSingle.vue b/src/views/AddPriceSingle.vue
@@ -182,24 +182,6 @@ export default {
       this.addPriceSingleForm.price_per = this.categoryPricePerList[0].key // init to 'KILOGRAM' because it's the most common use-case
       this.addPriceSingleForm.currency = this.appStore.getUserLastCurrencyUsed
     },
-    showBarcodeScannerDialog() {
-      this.barcodeScannerDialog = true
-    },
-    showBarcodeManualInputDialog() {
-      this.barcodeManualInputDialog = true
-    },
-    setProductCode(code) {
-      this.addPriceSingleForm.product = null
-      this.addPriceSingleForm.product_code = code
-      api
-        .getProductByCode(code)
-        .then((data) => {
-          this.addPriceSingleForm.product = data.id ? data : {'code': code, 'price_count': 0}
-        })
-        .catch((error) => {  // eslint-disable-line no-unused-vars
-          alert('Error: Open Prices server error')
-        })
-    },
     createPrice() {
       this.createPriceLoading = true
       this.appStore.setLastCurrencyUsed(this.addPriceSingleForm.currency)
@@ -227,7 +209,7 @@ export default {
           if (data['detail']) {
             alert(`Error: with input ${data['detail'][0]['input']}`)
           } else {
-            this.$router.push({ path: '/prices', query: { singleSuccess: 'true' } })
+            this.done()
           }
           this.createPriceLoading = false
         })
@@ -237,6 +219,9 @@ export default {
           this.createPriceLoading = false
         })
     },
+    done() {
+      this.$router.push({ path: '/dasboard', query: { singleSuccess: 'true' } })
+    }
   }
 }
 </script>
diff --git a/src/views/PriceList.vue b/src/views/PriceList.vue
@@ -22,20 +22,6 @@
   >
     {{ $t('Common.SignedIn') }}
   </v-snackbar>
-  <v-snackbar
-    v-model="singleSuccessMessage"
-    color="success"
-    :timeout="2000"
-  >
-    {{ $t('Common.PriceCreated') }}
-  </v-snackbar>
-  <v-snackbar
-    v-model="multipleSuccessMessage"
-    color="success"
-    :timeout="2000"
-  >
-    {{ $t('Common.Thanks') }}
-  </v-snackbar>
 </template>
 
 <script>
@@ -56,8 +42,6 @@ export default {
       loading: false,
       // success messages
       signinSuccessMessage: false,
-      singleSuccessMessage: false,
-      multipleSuccessMessage: false,
       // scroll
       handleDebouncedScroll: null,
     }
@@ -71,12 +55,6 @@ export default {
     if (this.$route.query.signinSuccess === 'true') {
       this.signinSuccessMessage = true
     }
-    if (this.$route.query.singleSuccess === 'true') {
-      this.singleSuccessMessage = true
-    }
-    if (this.$route.query.multipleSuccess === 'true') {
-      this.multipleSuccessMessage = true
-    }
   },
   unmounted() {
     window.removeEventListener('scroll', this.handleDebouncedScroll)

diff --git a/src/views/UserDashboard.vue b/src/views/UserDashboard.vue
@@ -28,6 +28,21 @@
       </v-btn>
     </v-col>
   </v-row>
+
+  <v-snackbar
+    v-model="singleSuccessMessage"
+    color="success"
+    :timeout="2000"
+  >
+    {{ $t('Common.PriceCreated') }}
+  </v-snackbar>
+  <v-snackbar
+    v-model="multipleSuccessMessage"
+    color="success"
+    :timeout="2000"
+  >
+    {{ $t('Common.Thanks') }}
+  </v-snackbar>
 </template>
 
 <script>
@@ -44,11 +59,15 @@ export default {
   },
   data() {
     return {
+      // data
       user: null,
       userPriceCount: null,
       userProofCount: null,
       userPriceList: [],
       loading: false,
+      // success messages
+      singleSuccessMessage: false,
+      multipleSuccessMessage: false,
     }
   },
   computed: {
@@ -68,6 +87,13 @@ export default {
     this.getUser()
     this.getUserProofCount()
     this.getPrices()
+    // success messages
+    if (this.$route.query.singleSuccess === 'true') {
+      this.singleSuccessMessage = true
+    }
+    if (this.$route.query.multipleSuccess === 'true') {
+      this.multipleSuccessMessage = true
+    }
   },
   methods: {
     getUser() {