Fix files

openfoodfacts · May 25, 2024 · d931f7f · d931f7f
1 parent dfdc95f
commit d931f7f
Show file tree

Hide file tree

Showing 50 changed files with 286 additions and 160 deletions.
diff --git a/eslint.config.js b/eslint.config.js
@@ -9,6 +9,8 @@ export default [
   },
   {
     rules: {
+      'no-unused-vars': 'warn',
+      'vue/no-mutating-props': ['error', { 'shallowOnly': true }],
       'vue/no-reserved-component-names': 'off',
       'vue/multi-word-component-names': 'off',
       'vue/max-attributes-per-line': 'off',

diff --git a/src/components/BarcodeScannerDialog.vue b/src/components/BarcodeScannerDialog.vue
@@ -27,7 +27,7 @@
 </template>
 
 <script>
-import { Html5Qrcode, Html5QrcodeScanType, Html5QrcodeSupportedFormats } from 'html5-qrcode'
+import { Html5Qrcode, Html5QrcodeScanType } from 'html5-qrcode'
 
 const config = {
   fps: 10,

diff --git a/src/components/Footer.vue b/src/components/Footer.vue
@@ -9,7 +9,7 @@
           </template>
         </i18n-t>
         <br />
-        <v-btn v-for="source in sourceList" class="mr-1" size="x-small" rounded="xl" active :prepend-icon="source.icon" :href="source.url" target="_blank">
+        <v-btn v-for="source in sourceList" :key="source.source" class="mr-1" size="x-small" rounded="xl" active :prepend-icon="source.icon" :href="source.url" target="_blank">
           {{ source.label }}
           <v-tooltip activator="parent" open-on-click location="top">{{ source.name }}</v-tooltip>
         </v-btn>
@@ -29,7 +29,7 @@ import constants from '../constants'
 
 export default {
   components: {
-    'OpenFoodFactsLink': defineAsyncComponent(() => import('../components/OpenFoodFactsLink.vue')),
+    OpenFoodFactsLink: defineAsyncComponent(() => import('../components/OpenFoodFactsLink.vue')),
   },
   data() {
     return {

diff --git a/src/components/LocationCard.vue b/src/components/LocationCard.vue
@@ -19,7 +19,7 @@ import utils from '../utils.js'
 
 export default {
   components: {
-    'PriceCountChip': defineAsyncComponent(() => import('../components/PriceCountChip.vue')),
+    PriceCountChip: defineAsyncComponent(() => import('../components/PriceCountChip.vue')),
   },
   props: {
     location: {

diff --git a/src/components/LocationSelectorDialog.vue b/src/components/LocationSelectorDialog.vue
@@ -45,6 +45,7 @@
                 class="mb-2"
                 width="100%"
                 v-for="location in results"
+                :key="getLocationUniqueID(location)"
                 elevation="1"
                 @click="selectLocation(location)">
                 <v-card-text>
@@ -57,7 +58,7 @@
             <v-col cols="12" sm="6" style="min-height:200px">
               <l-map ref="map" v-model:zoom="mapZoom" :center="mapCenter" :use-global-leaflet="false" @ready="initMap">
                 <l-tile-layer url="https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png" layer-type="base" name="OpenStreetMap"></l-tile-layer>
-                <l-marker v-for="location in results" :lat-lng="getLocationLatLng(location)">
+                <l-marker v-for="location in results" :key="getLocationUniqueID(location)" :lat-lng="getLocationLatLng(location)">
                   <l-popup>
                     <h4>{{ getLocationTitle(location, true, false, false) }}</h4>
                     {{ getLocationTitle(location, false, true, true) }}<br />

diff --git a/src/components/PriceActionMenuButton.vue b/src/components/PriceActionMenuButton.vue
@@ -42,12 +42,15 @@ import { defineAsyncComponent } from 'vue'
 
 export default {
   components: {
-    'PriceEditDialog': defineAsyncComponent(() => import('../components/PriceEditDialog.vue')),
-    'PriceDeleteConfirmationDialog': defineAsyncComponent(() => import('../components/PriceDeleteConfirmationDialog.vue'))
+    PriceEditDialog: defineAsyncComponent(() => import('../components/PriceEditDialog.vue')),
+    PriceDeleteConfirmationDialog: defineAsyncComponent(() => import('../components/PriceDeleteConfirmationDialog.vue'))
   },
   props: {
-    'price': null,
-    'style': {
+    price: {
+      type: Object,
+      default: null
+    },
+    style: {
       type: String,
       default: 'position:absolute;bottom:6px;right:0;'
     }

diff --git a/src/components/PriceCard.vue b/src/components/PriceCard.vue
@@ -41,26 +41,56 @@ import utils from '../utils.js'
 
 export default {
   components: {
-    'PriceCountChip': defineAsyncComponent(() => import('../components/PriceCountChip.vue')),
-    'ProductBrands': defineAsyncComponent(() => import('../components/ProductBrands.vue')),
-    'ProductQuantityChip': defineAsyncComponent(() => import('../components/ProductQuantityChip.vue')),
-    'ProductMissingChip': defineAsyncComponent(() => import('../components/ProductMissingChip.vue')),
-    'PriceOrigins': defineAsyncComponent(() => import('../components/PriceOrigins.vue')),
-    'PriceLabels': defineAsyncComponent(() => import('../components/PriceLabels.vue')),
-    'PricePriceRow': defineAsyncComponent(() => import('../components/PricePriceRow.vue')),
-    'PriceFooterRow': defineAsyncComponent(() => import('../components/PriceFooterRow.vue'))
+    PriceCountChip: defineAsyncComponent(() => import('../components/PriceCountChip.vue')),
+    ProductBrands: defineAsyncComponent(() => import('../components/ProductBrands.vue')),
+    ProductQuantityChip: defineAsyncComponent(() => import('../components/ProductQuantityChip.vue')),
+    ProductMissingChip: defineAsyncComponent(() => import('../components/ProductMissingChip.vue')),
+    PriceOrigins: defineAsyncComponent(() => import('../components/PriceOrigins.vue')),
+    PriceLabels: defineAsyncComponent(() => import('../components/PriceLabels.vue')),
+    PricePriceRow: defineAsyncComponent(() => import('../components/PricePriceRow.vue')),
+    PriceFooterRow: defineAsyncComponent(() => import('../components/PriceFooterRow.vue'))
   },
   props: {
-    'price': null,
-    'product': null,
-    'hideProductImage': false,
-    'hideProductTitle': false,
-    'hideProductDetails': false,
-    'hidePriceDate': false,
-    'hidePriceFooterRow': false,
-    'hidePriceLocation': false,
-    'hidePriceProof': false,
-    'readonly': false
+    price: {
+      type: Object,
+      default: null
+    },
+    product: {
+      type: Object,
+      default: null
+    },
+    hideProductImage: {
+      type: Boolean,
+      default: false
+    },
+    hideProductTitle: {
+      type: Boolean,
+      default: false
+    },
+    hideProductDetails: {
+      type: Boolean,
+      default: false
+    },
+    hidePriceDate: {
+      type: Boolean,
+      default: false
+    },
+    hidePriceFooterRow: {
+      type: Boolean,
+      default: false
+    },
+    hidePriceLocation: {
+      type: Boolean,
+      default: false
+    },
+    hidePriceProof: {
+      type: Boolean,
+      default: false
+    },
+    readonly: {
+      type: Boolean,
+      default: false
+    },
   },
   data() {
     return {

diff --git a/src/components/PriceCountChip.vue b/src/components/PriceCountChip.vue
@@ -9,8 +9,14 @@
 <script>
 export default {
   props: {
-    'count': null,
-    'withLabel': false
+    count: {
+      type: Number,
+      default: null
+    },
+    withLabel: {
+      type: Boolean,
+      default: false
+    },
   },
   methods: {
     getColor() {

diff --git a/src/components/PriceDeleteConfirmationDialog.vue b/src/components/PriceDeleteConfirmationDialog.vue
@@ -37,10 +37,13 @@ import api from '../services/api'
 
 export default {
   components: {
-    'PriceCard': defineAsyncComponent(() => import('../components/PriceCard.vue'))
+    PriceCard: defineAsyncComponent(() => import('../components/PriceCard.vue'))
   },
   props: {
-    'price': null,
+    price: {
+      type: Object,
+      default: null
+    },
   },
   data() {
     return {

diff --git a/src/components/PriceEditDialog.vue b/src/components/PriceEditDialog.vue
@@ -52,11 +52,14 @@ import api from '../services/api'
 
 export default {
   components: {
-    'PriceCard': defineAsyncComponent(() => import('../components/PriceCard.vue')),
-    'PriceInputRow': defineAsyncComponent(() => import('../components/PriceInputRow.vue')),
+    PriceCard: defineAsyncComponent(() => import('../components/PriceCard.vue')),
+    PriceInputRow: defineAsyncComponent(() => import('../components/PriceInputRow.vue')),
   },
   props: {
-    price: null,
+    price: {
+      type: Object,
+      default: null
+    },
   },
   data() {
     return {

diff --git a/src/components/PriceFooterRow.vue b/src/components/PriceFooterRow.vue
@@ -18,17 +18,29 @@ import { useAppStore } from '../store'
 
 export default {
   components: {
-    'PriceLocationChip': defineAsyncComponent(() => import('../components/PriceLocationChip.vue')),
-    'PriceOwnerChip': defineAsyncComponent(() => import('../components/PriceOwnerChip.vue')),
-    'RelativeDateTimeChip': defineAsyncComponent(() => import('../components/RelativeDateTimeChip.vue')),
-    'PriceProof': defineAsyncComponent(() => import('../components/PriceProof.vue')),
-    'PriceActionMenuButton': defineAsyncComponent(() => import('../components/PriceActionMenuButton.vue')),
+    PriceLocationChip: defineAsyncComponent(() => import('../components/PriceLocationChip.vue')),
+    PriceOwnerChip: defineAsyncComponent(() => import('../components/PriceOwnerChip.vue')),
+    RelativeDateTimeChip: defineAsyncComponent(() => import('../components/RelativeDateTimeChip.vue')),
+    PriceProof: defineAsyncComponent(() => import('../components/PriceProof.vue')),
+    PriceActionMenuButton: defineAsyncComponent(() => import('../components/PriceActionMenuButton.vue')),
   },
   props: {
-    'price': null,
-    'hidePriceLocation': false,
-    'hidePriceProof': false,
-    'readonly': false
+    price: {
+      type: Object,
+      default: null
+    },
+    hidePriceLocation: {
+      type: Boolean,
+      default: false
+    },
+    hidePriceProof: {
+      type: Boolean,
+      default: false
+    },
+    readonly: {
+      type: Boolean,
+      default: false
+    },
   },
   computed: {
     ...mapStores(useAppStore),

diff --git a/src/components/PriceInputRow.vue b/src/components/PriceInputRow.vue
@@ -46,7 +46,7 @@ import { defineAsyncComponent } from 'vue'
 
 export default {
   components: {
-    'ChangeCurrencyDialog': defineAsyncComponent(() => import('../components/ChangeCurrencyDialog.vue')),
+    ChangeCurrencyDialog: defineAsyncComponent(() => import('../components/ChangeCurrencyDialog.vue')),
   },
   props: {
     priceForm: null,  // price, currency, price_is_discounted, price_without_discount

diff --git a/src/components/PriceLocationChip.vue b/src/components/PriceLocationChip.vue
@@ -11,8 +11,14 @@ import utils from '../utils.js'
 
 export default {
   props: {
-    'price': null,
-    'readonly': false
+    price: {
+      type: Object,
+      default: null
+    },
+    readonly: {
+      type: Boolean,
+      default: false
+    },
   },
   computed: {
     priceLocationTitle() {

diff --git a/src/components/PriceOwnerChip.vue b/src/components/PriceOwnerChip.vue
@@ -8,8 +8,14 @@
 <script>
 export default {
   props: {
-    'price': null,
-    'readonly': false
+    price: {
+      type: Object,
+      default: null
+    },
+    readonly: {
+      type: Boolean,
+      default: false
+    },
   },
   methods: {
     goToUser() {

diff --git a/src/components/PricePriceRow.vue b/src/components/PricePriceRow.vue
@@ -24,10 +24,22 @@ import utils from '../utils.js'
 
 export default {
   props: {
-    'price': null,
-    'productQuantity': null,
-    'productQuantityUnit': constants.PRODUCT_QUANTITY_UNIT_G,
-    'hidePriceDate': false
+    price: {
+      type: Object,
+      default: null
+    },
+    productQuantity: {
+      type: Number,
+      default: null
+    },
+    productQuantityUnit: {
+      type: String,
+      default: constants.PRODUCT_QUANTITY_UNIT_G
+    },
+    hidePriceDate: {
+      type: Boolean,
+      default: false
+    },
   },
   data() {
     return {}

diff --git a/src/components/PriceProof.vue b/src/components/PriceProof.vue
@@ -22,7 +22,10 @@ export default {
     ProofCard,
   },
   props: {
-    'proof': null,
+    proof: {
+      type: Object,
+      default: null
+    },
   },
   data() {
     return {

diff --git a/src/components/ProductBrands.vue b/src/components/ProductBrands.vue
@@ -26,7 +26,7 @@ import { defineAsyncComponent } from 'vue'
 
 export default {
   components: {
-    'ProductBrandsDialog': defineAsyncComponent(() => import('../components/ProductBrandsDialog.vue')),
+    ProductBrandsDialog: defineAsyncComponent(() => import('../components/ProductBrandsDialog.vue')),
   },
   props: {
     productBrands: String,

diff --git a/src/components/ProductCard.vue b/src/components/ProductCard.vue
@@ -44,21 +44,33 @@ import { useAppStore } from '../store'
 
 export default {
   components: {
-    'PriceCountChip': defineAsyncComponent(() => import('../components/PriceCountChip.vue')),
-    'ProductBrands': defineAsyncComponent(() => import('../components/ProductBrands.vue')),
-    'ProductQuantityChip': defineAsyncComponent(() => import('../components/ProductQuantityChip.vue')),
-    'ProductCategoriesChip': defineAsyncComponent(() => import('../components/ProductCategoriesChip.vue')),
-    'ProductLabelsChip': defineAsyncComponent(() => import('../components/ProductLabelsChip.vue')),
-    'ProductMissingChip': defineAsyncComponent(() => import('../components/ProductMissingChip.vue')),
-    'ProductBarcodeChip': defineAsyncComponent(() => import('../components/ProductBarcodeChip.vue')),
-    'PricePriceRow': defineAsyncComponent(() => import('../components/PricePriceRow.vue')),
-    'PriceFooterRow': defineAsyncComponent(() => import('../components/PriceFooterRow.vue')),
+    PriceCountChip: defineAsyncComponent(() => import('../components/PriceCountChip.vue')),
+    ProductBrands: defineAsyncComponent(() => import('../components/ProductBrands.vue')),
+    ProductQuantityChip: defineAsyncComponent(() => import('../components/ProductQuantityChip.vue')),
+    ProductCategoriesChip: defineAsyncComponent(() => import('../components/ProductCategoriesChip.vue')),
+    ProductLabelsChip: defineAsyncComponent(() => import('../components/ProductLabelsChip.vue')),
+    ProductMissingChip: defineAsyncComponent(() => import('../components/ProductMissingChip.vue')),
+    ProductBarcodeChip: defineAsyncComponent(() => import('../components/ProductBarcodeChip.vue')),
+    PricePriceRow: defineAsyncComponent(() => import('../components/PricePriceRow.vue')),
+    PriceFooterRow: defineAsyncComponent(() => import('../components/PriceFooterRow.vue')),
   },
   props: {
-    'product': null,
-    'latestPrice': null,
-    'hideProductBarcode': false,
-    'readonly': false
+    product: {
+      type: Object,
+      default: null
+    },
+    latestPrice: {
+      type: Object,
+      default: null
+    },
+    hideProductBarcode: {
+      type: Boolean,
+      default: false
+    },
+    readonly: {
+      type: Boolean,
+      default: false
+    },
   },
   data() {
     return {