Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price form: improve location selector #37

Open
9 of 13 tasks
raphodn opened this issue Dec 20, 2023 · 4 comments · Fixed by #52, #58, #57, #600 or #808
Open
9 of 13 tasks

Price form: improve location selector #37

raphodn opened this issue Dec 20, 2023 · 4 comments · Fixed by #52, #58, #57, #600 or #808

Comments

@raphodn
Copy link
Member

raphodn commented Dec 20, 2023

Story

The location selector could be improved and simplified, to accelerate price collection

TODO

  • show recent locations directly in the form (instead of the modal)
  • hide OSM metadata (id & type), just display the location name
  • selector : show a map with the results
  • selector : hide non-shop results
  • show a helpful message if the location searched by the user is not found in Nominatim (maybe the location doesn't exist in OSM ?)
  • allow removing a recent location
  • improving full-text search : replace Nominatim with Photon Komoot : Improve location text search (alternative to Nominatim ?) --> Photon Komoot API #61

v2 ideas

Part of

@raphodn raphodn changed the title Price form: simplify location selector Price form: improve location selector Dec 23, 2023
@raphodn raphodn added the UI label Jan 8, 2024
@teolemon
Copy link
Member

teolemon commented Feb 7, 2024

@raphodn How about allowing to use the Device location, and proposing a list of shop candidates within a 500m radius ?

image

@Showmaster3000
Copy link

another thing is adding brand new locations. In my case, a completely new Aldi opened two weeks ago. I just mapped it last week via osm, but it is currently still missing via komoot api. Adding prices is therefore not possible.

@raphodn
Copy link
Member Author

raphodn commented Jun 19, 2024

another thing is adding brand new locations. In my case, a completely new Aldi opened two weeks ago. I just mapped it last week via osm, but it is currently still missing via komoot api. Adding prices is therefore not possible.

indeed we need to figure out the frequency of komoot's API updates...

in the meantime you can now search the location by its ID (#617)

@raphodn
Copy link
Member Author

raphodn commented Sep 20, 2024

Following a discussion on the mobile side - openfoodfacts/smooth-app#5568 - the default Photon search will now be restricted to osm_tag=shop&osm_tag=amenity (todo: offer a wider search if no results found)

@raphodn raphodn added the 🏄‍♀️ good first issue Good for newcomers label Sep 25, 2024
@github-actions github-actions bot added ⭐ top issue Top issue. and removed ⭐ top issue Top issue. labels Oct 1, 2024
@github-actions github-actions bot added the ⭐ top issue Top issue. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment