refactor(Price Validation Assistant): filter only on proofs ready (uploaded via Proof add pages) #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Thanks to a new Proof.ready_for_price_tag_validation field in the backend - openfoodfacts/open-prices#656.
We can now restrict displayed PriceTags to only a subset of Proofs.
Why
We consider that proofs added via the "normal" workflow (Price add multiple) will have their prices added normally.
But proofs added via the dedicated "proof upload" pages will be assistant-only for price addition.
This is a v1. To be discussed / improved.