refactor: remove perform_create to simplify code

openfoodfacts · Nov 6, 2024 · 2394940 · 2394940
1 parent a9188c9
commit 2394940
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/open_prices/api/locations/views.py b/open_prices/api/locations/views.py
@@ -36,10 +36,10 @@ def create(self, request: Request, *args, **kwargs):
         serializer = self.get_serializer(data=request.data)
         serializer.is_valid(raise_exception=True)
         # get source
-        self.source = get_source_from_request(self.request)
+        source = get_source_from_request(self.request)
         # save
         location = serializer.save(
-            source=self.source,
+            source=source,
         )
         # return full location
         return Response(

diff --git a/open_prices/api/prices/views.py b/open_prices/api/prices/views.py
@@ -52,17 +52,14 @@ def get_serializer_class(self):
             return PriceUpdateSerializer
         return self.serializer_class
 
-    def perform_create(self, serializer):
-        return serializer.save(owner=self.request.user.user_id, source=self.source)
-
     def create(self, request: Request, *args, **kwargs):
         # validate
         serializer = self.get_serializer(data=request.data)
         serializer.is_valid(raise_exception=True)
         # get source
-        self.source = get_source_from_request(self.request)
+        source = get_source_from_request(self.request)
         # save
-        price = self.perform_create(serializer)
+        price = serializer.save(owner=self.request.user.user_id, source=source)
         # return full price
         return Response(
             self.serializer_class(price).data, status=status.HTTP_201_CREATED

diff --git a/open_prices/api/proofs/views.py b/open_prices/api/proofs/views.py
@@ -95,11 +95,11 @@ def upload(self, request: Request) -> Response:
         serializer = ProofCreateSerializer(data=proof_create_data)
         serializer.is_valid(raise_exception=True)
         # get source
-        self.source = get_source_from_request(self.request)
+        source = get_source_from_request(self.request)
         # save
         proof = serializer.save(
             owner=self.request.user.user_id,
-            source=self.source,
+            source=source,
         )
         # return full proof
         return Response(ProofFullSerializer(proof).data, status=status.HTTP_201_CREATED)